chore: add enum for in_review

[thelostone-mc]

🤖 Linear

Closes PAR-XXX

Description

Checklist before requesting a review

• I have conducted a self-review of my code.
• I have conducted a QA.
• If it is a core feature, I have included comprehensive tests.

Summary by CodeRabbit

• New Features
  • Added two new application statuses: "CANCELLED" and "IN_REVIEW", allowing for more detailed tracking of application progress.
• Bug Fixes
  • Improved validation to support the new application statuses.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce two new application statuses: "CANCELLED" and "IN_REVIEW". These statuses are added to the ApplicationStatus enum in the constants file and to the ApplicationStatus string literal type in the types definition file. Additionally, the isValidApplicationStatus function is updated to recognize these new statuses as valid by expanding its accepted numeric range from 1–3 to 1–5. Corresponding test cases in multiple handler test suites are updated to reflect the new valid and invalid status values by adjusting the sets of tested invalid statuses. No other logic, types, or function signatures are altered. The updates collectively ensure that the new statuses are consistently recognized throughout the application’s type system, validation logic, and test coverage.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e1f064 and cfed17f.

📒 Files selected for processing (6)

• packages/processors/src/constants/enums.ts (1 hunks)
• packages/processors/src/processors/strategy/helpers/applicationStatus.ts (1 hunks)
• packages/processors/test/strategy/directGrantsLite/handlers/updatedRegistration.handler.spec.ts (1 hunks)
• packages/processors/test/strategy/donationVotingMerkleDistributionDirectTransfer/handlers/updatedRegistration.handler.spec.ts (1 hunks)
• packages/processors/test/strategy/easyRetroFunding/handlers/updatedRegistration.handler.spec.ts (1 hunks)
• packages/repository/src/types/application.types.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• packages/processors/src/constants/enums.ts
• packages/processors/src/processors/strategy/helpers/applicationStatus.ts
• packages/repository/src/types/application.types.ts

🧰 Additional context used

📓 Path-based instructions (2)

`**/*.ts`:

**/*.ts:

• packages/processors/test/strategy/directGrantsLite/handlers/updatedRegistration.handler.spec.ts
• packages/processors/test/strategy/donationVotingMerkleDistributionDirectTransfer/handlers/updatedRegistration.handler.spec.ts
• packages/processors/test/strategy/easyRetroFunding/handlers/updatedRegistration.handler.spec.ts

`**/*.spec.ts`: Review the unit test files with the following guidelines: - Avoid using the word "should" in test descriptions. - Ensure descriptive test names convey the inten...

**/*.spec.ts: Review the unit test files with the following guidelines:

• Avoid using the word "should" in test descriptions.
• Ensure descriptive test names convey the intent of each test.
• Validate adherence to the Mocha/Chai/Jest test library best practices.
• Be concise and avoid overly nitpicky feedback outside of these best practices.

• packages/processors/test/strategy/directGrantsLite/handlers/updatedRegistration.handler.spec.ts
• packages/processors/test/strategy/donationVotingMerkleDistributionDirectTransfer/handlers/updatedRegistration.handler.spec.ts
• packages/processors/test/strategy/easyRetroFunding/handlers/updatedRegistration.handler.spec.ts

🔇 Additional comments (3)

packages/processors/test/strategy/directGrantsLite/handlers/updatedRegistration.handler.spec.ts (1)

121-121: Updated invalid status test to match new status range.

The test has been correctly updated to use "10" as an invalid status instead of previously using "4". This aligns with the PR objective of extending the valid application status range from 1-3 to 1-5 (adding "CANCELLED" and "IN_REVIEW" statuses).

packages/processors/test/strategy/easyRetroFunding/handlers/updatedRegistration.handler.spec.ts (1)

124-124: Updated invalid status test cases to reflect new valid status range.

The invalid status test cases have been properly updated from ["0", "4", "10"] to ["0", "6", "10"], which correctly accounts for the extended valid status range (now 1-5 instead of 1-3). This ensures the test properly validates the behavior with the new "CANCELLED" and "IN_REVIEW" statuses.

packages/processors/test/strategy/donationVotingMerkleDistributionDirectTransfer/handlers/updatedRegistration.handler.spec.ts (1)

124-124: Updated invalid status test cases to match extended valid status range.

The invalid status test cases have been appropriately updated from ["0", "4", "10"] to ["0", "6", "10"], which correctly accounts for the new valid status range of 1-5 (previously 1-3). This change ensures consistent test coverage across all handler implementations.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/processors/src/processors/strategy/helpers/applicationStatus.ts (1)

8-8: Function logic updated correctly, but documentation needs updating.

The function logic has been properly updated to accept status values from 1 to 5, which covers the new CANCELLED and IN_REVIEW statuses. However, the JSDoc comment above (line 4) still mentions "between 1 and 3" and should be updated.

 /**
- * Checks if an application status index is valid (between 1 and 3)
+ * Checks if an application status index is valid (between 1 and 5)
  * @see ApplicationStatus
  */

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37ebd66 and 3e1f064.

📒 Files selected for processing (3)

• packages/processors/src/constants/enums.ts (1 hunks)
• packages/processors/src/processors/strategy/helpers/applicationStatus.ts (1 hunks)
• packages/repository/src/types/application.types.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.ts`:

**/*.ts:

• packages/processors/src/constants/enums.ts
• packages/repository/src/types/application.types.ts
• packages/processors/src/processors/strategy/helpers/applicationStatus.ts

🔇 Additional comments (2)

packages/repository/src/types/application.types.ts (1)

3-3: Added new application statuses correctly.

Good job adding the new statuses "CANCELLED" and "IN_REVIEW" to the ApplicationStatus type definition. This aligns with the PR objective and ensures type safety across the codebase for these new status values.

packages/processors/src/constants/enums.ts (1)

6-7: New enum values properly added.

The addition of CANCELLED and IN_REVIEW enum values is consistent with the type definition changes in application.types.ts. The new values will be implicitly assigned 4 and 5 respectively, which aligns with the updated validation logic.