gitk: text wrapping in ctext (commit headers, subject, and body) #1835
Conversation
Make preference groups like "Diff display options" stand out more. Signed-off-by: Christoph Sommer <[email protected]>
Add a new preference "wrapdefault" which allows enabling char/word wrap. Impacts all text in the ctext widget for which no other preference exists. Also make the (existing) preference "wrapcomment" configurable graphically. Its setting impacts only the "comment" part of the ctext widget. Signed-off-by: Christoph Sommer <[email protected]>
Welcome to GitGitGadgetHi @sommer, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that either:
You can CC potential reviewers by adding a footer to the PR description with the following syntax: NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description, Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form Both the person who commented An alternative is the channel Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment If you want to see what email(s) would be sent for a After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail). If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the curl -g --user "<EMailAddress>:<Password>" \
--url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txtTo iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description): To send a new iteration, just add another PR comment with the contents: Need help?New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join. You may also be able to find help in real time in the developer IRC channel, |
|
/preview |
|
Error: User sommer is not yet permitted to use GitGitGadget |
|
/allow |
|
User sommer is now allowed to use GitGitGadget. |
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| global NS maxwidth maxgraphpct showneartags showlocalchanges | ||
| global tabstop limitdiffs autoselect autosellen extdifftool perfile_attrs | ||
| global hideremotes want_ttk have_ttk maxrefs web_browser | ||
|
|
There was a problem hiding this comment.
On the Git mailing list, Johannes Sixt wrote (reply to this):
Am 09.12.24 um 19:08 schrieb Christoph Sommer via GitGitGadget:
> From: Christoph Sommer <[email protected]>
>
> Make preference groups like "Diff display options" stand out more.
This is a nice and obvious improvement.
-- Hannes
|
User |
| global tabstop | ||
| global findtype findtypemenu findloc findstring fstring geometry | ||
| global entries sha1entry sha1string sha1but | ||
| global diffcontextstring diffcontext |
There was a problem hiding this comment.
On the Git mailing list, Johannes Sixt wrote (reply to this):
Am 09.12.24 um 19:08 schrieb Christoph Sommer via GitGitGadget:
> From: Christoph Sommer <[email protected]>
>
> Add a new preference "wrapdefault" which allows enabling char/word wrap.
> Impacts all text in the ctext widget for which no other preference exists.
>
> Also make the (existing) preference "wrapcomment" configurable graphically.
> Its setting impacts only the "comment" part of the ctext widget.
Nice! I agree that it makes sense to wrap the comment differently than
the patch text section. I notice, though, that the patch text wrapping
is also applied to the commit header section. Personally, I don't mind
it. If someone needs a third option, they can take this patch as a
blueprint.
-- Hannes
|
This patch series was integrated into seen via git@904b36b. |
|
This patch series was integrated into master via git@904b36b. |
|
This patch series was integrated into next via git@904b36b. |
|
Closed via 904b36b. |
2 participants
Using gitk to view diffs of source code without hard linebreaks is a bit painful without dynamic word wrapping, for which I could not find a preference. The only related one I found was for wrapping the commit subject (called a comment in the source code, I guess), and that did not seem to be reconfigurable in a running gitk.
On the off chance that such features might also be useful to somebody else I am sharing them publicly, as two semi-related changes:
gitk: add text wrapping preferences
Add a new preference "wrapdefault" which allows enabling char/word wrap.
Impacts all text in the ctext widget for which no other preference exists.
Also make the (existing) preference "wrapcomment" configurable graphically.
Its setting impacts only the "comment" part of the ctext widget.
gitk: make headings of preferences bold
Make preference groups like "Diff display options" stand out more.
cc: Johannes Sixt [email protected]