Remove duplicate forward declaration of struct repository

[Ethan0456]

Summary

While exploring how Git searches for .gitignore files and manages ignored files, I came across dir.h. While reading through the file, I noticed that struct repository; was forward-declared twice. This duplication appears unnecessary, and removing the second declaration compiles cleanly.

[Ethan0456]

/preview

[gitgitgadget]

Preview email sent as [email protected]

[Ethan0456]

/submit

[gitgitgadget]

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1879/Ethan0456/cleanup/deduplicate-repo-fwd-decl-v1

To fetch this version to local tag pr-1879/Ethan0456/cleanup/deduplicate-repo-fwd-decl-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1879/Ethan0456/cleanup/deduplicate-repo-fwd-decl-v1

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Abhijeetsingh Meena via GitGitGadget" <[email protected]>
writes:

> From: Abhijeetsingh Meena <[email protected]>
>
> The `struct repository;` forward declaration appears twice in `dir.h`:
> once at line 10 and again at line 46. This duplication is unnecessary
> and likely unintentional.
>
> Removing the second declaration has no impact on compilation, as verified
> by a clean build.
>
> Signed-off-by: Abhijeetsingh Meena <[email protected]>
> ---

Thanks.  Will apply.

>  dir.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/dir.h b/dir.h
> index a3a2f00f5d9..e659c47ad77 100644
> --- a/dir.h
> +++ b/dir.h
> @@ -43,7 +43,6 @@ struct repository;
>   *
>   */
>  
> -struct repository;
>  
>  struct dir_entry {
>  	unsigned int len;
>
> base-commit: ef8ce8f3d4344fd3af049c17eeba5cd20d98b69f

[gitgitgadget]

This patch series was integrated into seen via git@94dfd81.

[gitgitgadget]

This branch is now known as am/dir-dedup-decl-of-repository.

[gitgitgadget]

This patch series was integrated into seen via git@f6da788.

[gitgitgadget]

There was a status update in the "New Topics" section about the branch am/dir-dedup-decl-of-repository on the Git mailing list:

Code cleanup.

Will merge to 'next'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@48e4fa7.

[gitgitgadget]

This patch series was integrated into seen via git@dd46f94.

[gitgitgadget]

There was a status update in the "Cooking" section about the branch am/dir-dedup-decl-of-repository on the Git mailing list:

Code cleanup.

Will merge to 'next'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@fcc0a1e.

[gitgitgadget]

This patch series was integrated into seen via git@e06c63b.

[gitgitgadget]

This patch series was integrated into seen via git@898b000.

[gitgitgadget]

This patch series was integrated into seen via git@2278c08.

[gitgitgadget]

This patch series was integrated into seen via git@03e8ba1.

[gitgitgadget]

This patch series was integrated into next via git@9075454.

[gitgitgadget]

This patch series was integrated into seen via git@3e03cdb.

[gitgitgadget]

There was a status update in the "Cooking" section about the branch am/dir-dedup-decl-of-repository on the Git mailing list:

Code cleanup.

Will merge to 'master'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@1cd5a5b.

[gitgitgadget]

There was a status update in the "Cooking" section about the branch am/dir-dedup-decl-of-repository on the Git mailing list:

Code cleanup.

Will merge to 'master'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@055cbd4.

[gitgitgadget]

This patch series was integrated into seen via git@77f9b97.

[gitgitgadget]

There was a status update in the "Cooking" section about the branch am/dir-dedup-decl-of-repository on the Git mailing list:

Code cleanup.

Will merge to 'master'.
source: <[email protected]>

[gitgitgadget]

This patch series was integrated into seen via git@e91937e.

[gitgitgadget]

This patch series was integrated into seen via git@f3db666.

[gitgitgadget]

This patch series was integrated into master via git@f3db666.

[gitgitgadget]

This patch series was integrated into next via git@f3db666.

[gitgitgadget]

Closed via f3db666.