Skip to content

Conversation

AyuSharma176
Copy link

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

For a single-commit pull request, please leave the pull request description
empty
: your commit message itself should describe your changes.

Please read the "guidelines for contributing" linked above!

Copy link

gitgitgadget bot commented Aug 14, 2025

Welcome to GitGitGadget

Hi @AyuSharma176, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

  • Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
  • Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <[email protected]>, Ill Takalook <[email protected]>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

Copy link

gitgitgadget bot commented Aug 14, 2025

There are issues in commit 8e786d4:
psuh: display the top of origin/master
Commit checks stopped - the message is too short
Commit not signed off

Copy link

gitgitgadget bot commented Aug 14, 2025

There are issues in commit 355f367:
psuh: show parameters & config opts
Commit checks stopped - the message is too short
Commit not signed off

@AyuSharma176
Copy link
Author

Hello, I am a new contributor following the "MyFirstContribution" tutorial. Could someone please grant me permission to use GitGitGadget by commenting /allow AyuSharma176 on my pull request?

Here is the link to my PR: #1954

Thank you!

Copy link

gitgitgadget bot commented Aug 14, 2025

There is a merge commit in this Pull Request:

c7387f6755e94d13c8795396798784fc24d549dd

Please rebase the branch and force-push.

@AyuSharma176 AyuSharma176 changed the title Psuh Add psuh Command Aug 14, 2025
monarch added 2 commits August 14, 2025 14:23
Internal metrics indicate this is a command many users expect to be
present. So here's an implementation to help drive customer
satisfaction and engagement: a pony which doubtfully greets the user,
or, a Pony Saying "Um, Hello" (PSUH).

This commit message is intentionally formatted to 72 columns per line,
starts with a single line as "commit message subject" that is written as
if to command the codebase to do something (add this, teach a command
that). The body of the message is designed to add information about the
commit that is not readily deduced from reading the associated diff,
such as answering the question "why?".

Signed-off-by: A U Thor <[email protected]>

Signed-off-by: monarch <[email protected]>
Copy link

gitgitgadget bot commented Aug 14, 2025

There are issues in commit 656cb67:
psuh: display the top of origin/master
Commit checks stopped - the message is too short
Commit not signed off

monarch added 5 commits August 14, 2025 14:30
Use the lookup_commit_reference_by_name() and pp_commit_easy()
helpers to find and print the summary of the commit at the
tip of the upstream master branch.

Signed-off-by: monarch <[email protected]>
Add a manpage for the new 'psuh' command, as is standard for all
user-facing git commands.

This documentation allows users to run 'git help psuh' to see
the command's synopsis and description.

Signed-off-by: Your Name [email protected]
Implement usage text by integrating the parse-options API. This makes
the command more robust by handling help flags like -h and --help
gracefully instead of crashing.

This also updates command-list.txt to make the 'psuh' command
discoverable in the main 'git help' list.

Signed-off-by: Your Name [email protected]
Add a test script for the new 'psuh' command.

This test ensures the command runs without crashing and produces some
expected output, which will help prevent future regressions. It also
verifies that the command can correctly read the user.name
configuration from the test's sandboxed environment.

Signed-off-by: Your Name [email protected]
monarch and others added 2 commits August 14, 2025 14:50
Use the lookup_commit_reference_by_name() and pp_commit_easy()
helpers to find and print the summary of the commit at the
tip of the upstream master branch.

Signed-off-by: monarch <[email protected]>
Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 2d13dee: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 2d13dee: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 4e2ca65: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 11a64b1: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 417c277: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 2d13dee: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 4e2ca65: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 11a64b1: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 417c277: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 2d13dee: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 4e2ca65: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 11a64b1: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 417c277: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in d16e8fe: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 7d18d01: "[email protected]"

Copy link

gitgitgadget bot commented Aug 14, 2025

Invalid author email in 2d8a08b: "[email protected]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant