Skip to content

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 8, 2025

Following in the footsteps of the many, many recent #include refactorings, this patch series orders the #include statements in compat/mingw.c.

cc: Patrick Steinhardt [email protected]

dscho added 2 commits October 8, 2025 11:03
We want to make them relative to the top-level directory.

Signed-off-by: Johannes Schindelin <[email protected]>
It allows for more consistent patches that way.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Oct 8, 2025
@dscho
Copy link
Member Author

dscho commented Oct 9, 2025

/submit

Copy link

gitgitgadget bot commented Oct 9, 2025

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1985/dscho/organize-mingw-includes-v1

To fetch this version to local tag pr-1985/dscho/organize-mingw-includes-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1985/dscho/organize-mingw-includes-v1

Copy link

gitgitgadget bot commented Oct 10, 2025

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

On Thu, Oct 09, 2025 at 07:45:59AM +0000, Johannes Schindelin via GitGitGadget wrote:
> Following in the footsteps of the many, many recent #include refactorings,
> this patch series orders the #include statements in compat/mingw.c.

Both of these patches look good to me and I like the improved
consistency that they bring. I may also do the same for our code in
"refs/", where some of the files use relative includes, as well. Might
be worth to document this somewhere if it isn't already, but that
doesn't have to be part of your patch series here.

Sorting them also makes sense. It's another thing where I wish that we
had a tool to enforce this. clang-format supports this in theory, but
it's disabled right now. And I'm not even sure whether it can be told to
include e.g. "git-compat-util.h" first.

Thanks!

Patrick

Copy link

gitgitgadget bot commented Oct 10, 2025

User Patrick Steinhardt <[email protected]> has been added to the cc: list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant