Skip to content

Conversation

@Fredi-raspall
Copy link
Contributor

@Fredi-raspall Fredi-raspall commented Dec 30, 2025

On top of #1164

Remove dont-merge lable once #1164 merges and this PR points to main.

@Fredi-raspall Fredi-raspall requested a review from a team as a code owner December 30, 2025 16:56
@Fredi-raspall Fredi-raspall changed the base branch from main to pr/fredi/k8s-less December 30, 2025 16:57
@Fredi-raspall Fredi-raspall added the ci:-upgrade Disable VLAB upgrade tests label Dec 30, 2025
@qmonnet qmonnet requested a review from Copilot January 5, 2026 17:14
@Fredi-raspall Fredi-raspall requested review from mvachhar and removed request for Copilot January 5, 2026 17:14
Copy link
Contributor

@mvachhar mvachhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me very happy. We should archive the gateway proto after it merges. @Frostman are we good to go on the fabricator/fabric side to drop gRPC?

@mvachhar mvachhar requested a review from Frostman January 5, 2026 21:18
@mvachhar mvachhar added dont-merge Do not merge this Pull Request and removed ci:-upgrade Disable VLAB upgrade tests labels Jan 5, 2026
@mvachhar
Copy link
Contributor

mvachhar commented Jan 5, 2026

Enabled ci upgrade test here especially from gRPC to not gRPC version.

@Frostman
Copy link
Member

Frostman commented Jan 5, 2026

@mvachhar yeah, we've switched to forced agentless on Dec 18

@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/k8s-less branch 2 times, most recently from 872d6ed to 0a33e9e Compare January 7, 2026 13:53
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/remove_grpc branch 2 times, most recently from 806028b to 18d421a Compare January 8, 2026 12:16
@mvachhar mvachhar mentioned this pull request Jan 8, 2026
Base automatically changed from pr/fredi/k8s-less to main January 8, 2026 18:48
* Remove launching of gRPC interface in management
* Remove args to pass gRPC address

Signed-off-by: Fredi Raspall <[email protected]>
@Fredi-raspall Fredi-raspall added ci:-upgrade Disable VLAB upgrade tests and removed dont-merge Do not merge this Pull Request labels Jan 8, 2026
@Fredi-raspall Fredi-raspall added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 6d39e19 Jan 8, 2026
22 of 24 checks passed
@Fredi-raspall Fredi-raspall deleted the pr/fredi/remove_grpc branch January 8, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:-upgrade Disable VLAB upgrade tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants