routing test fixes #1193
Merged
routing test fixes #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable dependency features. Otherwise tests can't be run standalone. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
requested review from
daniel-noland
and removed request for
a team
Fredi-raspall
added
ci:-upgrade
qmonnet
requested changes
Jan 14, 2026
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
One nit below, looks good otherwise
qmonnet
approved these changes
Jan 14, 2026
The fibtable concurrency test takes more time than nearly all of the tests, and can even take nearly a minute. Scale it down to keep test run times low. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
force-pushed
the
pr/fredi/fix_routing_test_deps
branch
from
44b3beb to
7d52d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.