ci: Disable VLAB tests for Pull Request by default#1246
Merged
Conversation
qmonnet
requested review from
Frostman,
mvachhar and
sergeymatov
and removed request for
a team and
sergeymatov
Member
Author
|
We discussed some alternatives on Slack, but let's disable VLAB tests for PRs on dataplane until we have the time to implement these. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The VLAB tests take a long time to run, and we run them both for the PR and in the merge queue. This commit disables them, by default, for Pull Requests, but they remain enabled for the merge queue. The idea is to save time for most Pull Requests. If the VLAB tests break, we'll still catch it from the merge queue - it's not ideal as we prefer early feedback, but we don't expect this to happen very often. We can revisit if the assumption doesn't hold. For changes that are more likely to change the way the dataplane interacts with the fabric, contributors can, and should, enable VLAB tests explicitly by adding the "ci:+vlab" label to their Pull Request before running the checks. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/qmonnet/ci-disable-vlab-default
branch
from
3ee9b56 to
63a6d86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VLAB tests take a long time to run, and we run them both for the PR and in the merge queue. This commit disables them, by default, for Pull Requests, but they remain enabled for the merge queue.
The idea is to save time for most Pull Requests. If the VLAB tests break, we'll still catch it from the merge queue - it's not ideal as we prefer early feedback, but we don't expect this to happen very often. We can revisit if the assumption doesn't hold.
For changes that are more likely to change the way the dataplane interacts with the fabric, contributors can, and should, enable VLAB tests explicitly by adding the "ci:+vlab" label to their Pull Request before running the checks.
This is one part of various changes that we've recently discussed to shorten CI duration for dataplane.