Skip to content

Clean up code in flow-filter table management #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmonnet merged 6 commits into from
Feb 9, 2026
Merged

Clean up code in flow-filter table management #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7d764b
chore(config): Simplify has_host_prefixes() methods
qmonnet Feb 5, 2026
2e64b05
refactor(flow-filter): Extract generic PortRangeMap type
qmonnet Feb 4, 2026
8acb984
refactor(flow-filter): Use HashMap entry API in FlowFilterTable
qmonnet Feb 4, 2026
484f9c3
refactor(flow-filter): Consolidate default_source methods
qmonnet Feb 4, 2026
49cfaff
refactor(flow-filter): Remove redundant _opt suffix from field name
qmonnet Feb 4, 2026
d21ad6e
refactor(flow-filter): Improve FlowFilterTable documentation
qmonnet Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions config/src/external/overlay/vpcpeering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ impl VpcExpose {
}
#[must_use]
pub fn has_host_prefixes(&self) -> bool {
self.ips.iter().filter(|p| p.prefix().is_host()).count() > 0
self.ips.iter().any(|p| p.prefix().is_host())
}

/// The prefixes of an expose to be advertised to a remote peer
Expand Down Expand Up @@ -503,11 +503,7 @@ impl VpcManifest {
}
#[must_use]
pub fn has_host_prefixes(&self) -> bool {
self.exposes
.iter()
.filter(|expose| expose.has_host_prefixes())
.count()
> 0
self.exposes.iter().any(|expose| expose.has_host_prefixes())
}
fn validate_expose_collisions(&self) -> ConfigResult {
// Check that prefixes in each expose don't overlap with prefixes in other exposes
Expand Down
Loading
Loading