feat: Preserve DSCP and ECN if present of ingress#1271
Open
sergeymatov wants to merge 1 commit intomainfrom
Open
feat: Preserve DSCP and ECN if present of ingress#1271sergeymatov wants to merge 1 commit intomainfrom
sergeymatov wants to merge 1 commit intomainfrom
Conversation
Contributor
sergeymatov
commented
Feb 9, 2026
sergeymatov
commented
- on ingress decapsulation routine we preserve DSCP and ECN fields
- on egress fetch saved from metadata DSCP and ECN values if present and reflect it on outer header
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
requested review from
daniel-noland
and removed request for
a team
mvachhar
requested changes
Feb 9, 2026
Contributor
mvachhar
left a comment
mvachhar
left a comment
There was a problem hiding this comment.
Just a few comments to address. It may be that no changes are needed with a short explanation, or some changes might be needed. In particular, how much harder is it to just add IPv6 for this? Also, are there any tests that we can add (unit tests in particular) to make sure we are doing the right thing here?
| self.meta.dscp = Some(Dscp::from(ipv4.dscp())); | ||
| self.meta.ecn = Some(Ecn::from(ipv4.ecn())); | ||
| } else { | ||
| // Not IPv4 underlay - unsupported now |
Contributor
There was a problem hiding this comment.
Why not extract these for v6 as well? How much harder is that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.