chore(hhfctl): migrate to urfave v3 #1242
Draft
+6,453
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR migrates the hhfctl command-line tool from urfave/cli/v2 to urfave/cli/v3. The migration involves updating function signatures to match v3's API, which introduces context.Context as the first parameter and changes the CLI context parameter from *cli.Context to *cli.Command.
Key changes:
- Updated import from
github.com/urfave/cli/v2togithub.com/urfave/cli/v3 - Modified all
BeforeandActionfunction signatures to acceptcontext.Contextas first parameter - Replaced
*cli.Contextwith*cli.Commandin action handlers - Renamed API properties (
App→Command,Subcommands→Commands,EnableBashCompletion→EnableShellCompletion)
Reviewed changes
Copilot reviewed 2 out of 49 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Added dependency on urfave/cli/v3 v3.0.0-alpha9 |
| cmd/hhfctl/main.go | Migrated all CLI command definitions and handlers to v3 API patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Temp artifacts published: |
pau-hedgehog
force-pushed
the
pau/hhfctl-urfave-v3
branch
from
d0181ff to
4084f7f
Compare
|
🚀 Temp artifacts published: |
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
pau-hedgehog
force-pushed
the
pau/hhfctl-urfave-v3
branch
from
4084f7f to
db33b30
Compare
|
🚀 Temp artifacts published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.