Skip to content

feat: Have sudo run the user's shell when calling config.sh from start-runner.sh #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

feat: Have sudo run the user's shell when calling config.sh from start-runner.sh #3768

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c17cdb
feat: Have sudo run the user's shell when calling config.sh from star…
bshelton229 Feb 12, 2024
5b60b0f
Merge branch 'main' into sudo-config-shell-login
bshelton229 Feb 14, 2024
a6c5386
Merge branch 'main' into sudo-config-shell-login
npalm Feb 20, 2024
e41e29e
Merge branch 'main' into sudo-config-shell-login
npalm Mar 13, 2024
05e0437
Merge branch 'main' into sudo-config-shell-login
npalm Apr 16, 2024
177c96b
Merge branch 'main' into sudo-config-shell-login
npalm Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/runners/templates/start-runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ echo "Starting the runner as user $run_as"
# configure the runner if the runner is non ephemeral or jit config is disabled
if [[ "$enable_jit_config" == "false" || $agent_mode != "ephemeral" ]]; then
echo "Configure GH Runner as user $run_as"
sudo --preserve-env=RUNNER_ALLOW_RUNASROOT -u "$run_as" -- ./config.sh --unattended --name "$runner_name_prefix$instance_id" --work "_work" $${config}
sudo --preserve-env=RUNNER_ALLOW_RUNASROOT -i -u "$run_as" -- $PWD/config.sh --unattended --name "$runner_name_prefix$instance_id" --work "_work" $${config}
fi

create_xray_success_segment "$SEGMENT"
Expand Down