Skip to content

fix(lambda): Prevent scale-up lambda from starting runner for user repo if org level runners is enabled #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 16, 2024

Merge branch 'main' into reject_user_action_when_org_enabled_v2

a0fe16c
Select commit
Loading
Failed to load commit list.
Merged

fix(lambda): Prevent scale-up lambda from starting runner for user repo if org level runners is enabled #3909

Merge branch 'main' into reject_user_action_when_org_enabled_v2
a0fe16c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 15, 2024 in 36s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (8.82 -> 8.81)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scale-up.ts: scaleUp 🔥

✅ Improving Code Health:

  • Overall Code Complexity scale-up.ts 🔥

Annotations

Check warning on line 263 in lambdas/functions/control-plane/src/scale-runners/scale-up.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

scaleUp increases in cyclomatic complexity from 23 to 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in lambdas/functions/control-plane/src/scale-runners/scale-up.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity 

The mean cyclomatic complexity decreases from 4.92 to 4.79, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis