refactor: split webhook accepting and queue dispatching logic #4160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
commented
Oct 2, 2024
stuartp44
reviewed
Oct 2, 2024
stuartp44
requested changes
Oct 2, 2024
stuartp44
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refacting the webhook lambda. It splits the webhook logic in a part responsible to accept the event and a part to dispatch to the runner queues. Secondly it refactor and removes duplicate logic in tests.
This change should allow to split the lambda in two lambda and and use the AWS EventBridge to accept events, and use the dispacher only for delegating an event to a runner queueu.