Skip to content

fix: Add prefix to the policies which breaks multi runner configuration #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Add prefix to the policies which breaks multi runner configuration #4341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2434669
fix: Add prefix to the policies which breaks multi runner configuration
prashanthbgoud Jan 7, 2025
f98243d
fix: Add prefix to the policies which breaks multi runner configuration
prashanthbgoud Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/ami-housekeeper/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
}

resource "aws_iam_role_policy" "lambda_logging" {
name = "logging-policy"
name = "${var.prefix}-logging-policy"
role = aws_iam_role.ami_housekeeper.id

policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
Expand All @@ -93,7 +93,7 @@ resource "aws_iam_role_policy" "lambda_logging" {
}

resource "aws_iam_role_policy" "ami_housekeeper" {
name = "lambda-ami-policy"
name = "${var.prefix}-lambda-ami-policy"
role = aws_iam_role.ami_housekeeper.id

policy = templatefile("${path.module}/policies/lambda-ami-housekeeper.json", {})
Expand Down Expand Up @@ -127,7 +127,7 @@ resource "aws_lambda_permission" "ami_housekeeper" {

resource "aws_iam_role_policy" "ami_housekeeper_xray" {
count = var.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.ami_housekeeper.name
}
4 changes: 2 additions & 2 deletions modules/lambda/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
}

resource "aws_iam_role_policy" "lambda_logging" {
name = "logging-policy"
name = "${var.lambda.prefix}-logging-policy"
role = aws_iam_role.main.id

policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
Expand All @@ -106,7 +106,7 @@ resource "aws_iam_role_policy_attachment" "vpc_execution_role" {

resource "aws_iam_role_policy" "xray" {
count = var.lambda.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.lambda.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.main.name
}
4 changes: 2 additions & 2 deletions modules/runner-binaries-syncer/runner-binaries-syncer.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ data "aws_iam_policy_document" "lambda_assume_role_policy" {
}

resource "aws_iam_role_policy" "lambda_logging" {
name = "logging-policys"
name = "${var.prefix}-logging-policys"
role = aws_iam_role.syncer_lambda.id

policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
Expand All @@ -112,7 +112,7 @@ resource "aws_iam_role_policy" "lambda_logging" {
}

resource "aws_iam_role_policy" "syncer" {
name = "s3-policy"
name = "${var.prefix}-s3-policy"
role = aws_iam_role.syncer_lambda.id

policy = templatefile("${path.module}/policies/lambda-syncer.json", {
Expand Down
6 changes: 3 additions & 3 deletions modules/runners/pool/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ resource "aws_iam_role" "pool" {
}

resource "aws_iam_role_policy" "pool" {
name = "pool-policy"
name = "${var.config.prefix}-pool-policy"
role = aws_iam_role.pool.name
policy = templatefile("${path.module}/policies/lambda-pool.json", {
arn_ssm_parameters_path_config = var.config.arn_ssm_parameters_path_config
Expand All @@ -94,7 +94,7 @@ resource "aws_iam_role_policy" "pool" {
}

resource "aws_iam_role_policy" "pool_logging" {
name = "logging-policy"
name = "${var.config.prefix}-logging-policy"
role = aws_iam_role.pool.name
policy = templatefile("${path.module}/../policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.pool.arn
Expand Down Expand Up @@ -144,7 +144,7 @@ data "aws_iam_policy_document" "lambda_xray" {

resource "aws_iam_role_policy" "pool_xray" {
count = var.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.config.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.pool.name
}
Expand Down
6 changes: 3 additions & 3 deletions modules/runners/scale-down.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ resource "aws_iam_role" "scale_down" {
}

resource "aws_iam_role_policy" "scale_down" {
name = "scale-down-policy"
name = "${var.prefix}-scale-down-policy"
role = aws_iam_role.scale_down.name
policy = templatefile("${path.module}/policies/lambda-scale-down.json", {
environment = var.prefix
Expand All @@ -103,7 +103,7 @@ resource "aws_iam_role_policy" "scale_down" {
}

resource "aws_iam_role_policy" "scale_down_logging" {
name = "logging-policy"
name = "${var.prefix}-logging-policy"
role = aws_iam_role.scale_down.name
policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.scale_down.arn
Expand All @@ -118,7 +118,7 @@ resource "aws_iam_role_policy_attachment" "scale_down_vpc_execution_role" {

resource "aws_iam_role_policy" "scale_down_xray" {
count = var.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.scale_down.name
}
10 changes: 5 additions & 5 deletions modules/runners/scale-up.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ resource "aws_iam_role" "scale_up" {
}

resource "aws_iam_role_policy" "scale_up" {
name = "scale-up-policy"
name = "${var.prefix}-scale-up-policy"
role = aws_iam_role.scale_up.name
policy = templatefile("${path.module}/policies/lambda-scale-up.json", {
arn_runner_instance_role = aws_iam_role.runner.arn
Expand All @@ -122,7 +122,7 @@ resource "aws_iam_role_policy" "scale_up" {
}

resource "aws_iam_role_policy" "scale_up_logging" {
name = "logging-policy"
name = "${var.prefix}-logging-policy"
role = aws_iam_role.scale_up.name
policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.scale_up.arn
Expand All @@ -131,7 +131,7 @@ resource "aws_iam_role_policy" "scale_up_logging" {

resource "aws_iam_role_policy" "service_linked_role" {
count = var.create_service_linked_role_spot ? 1 : 0
name = "service_linked_role"
name = "${var.prefix}-service_linked_role"
role = aws_iam_role.scale_up.name
policy = templatefile("${path.module}/policies/service-linked-role-create-policy.json", { aws_partition = var.aws_partition })
}
Expand All @@ -150,14 +150,14 @@ resource "aws_iam_role_policy_attachment" "ami_id_ssm_parameter_read" {

resource "aws_iam_role_policy" "scale_up_xray" {
count = var.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.scale_up.name
}

resource "aws_iam_role_policy" "job_retry_sqs_publish" {
count = local.job_retry_enabled ? 1 : 0
name = "publish-retry-check-sqs-policy"
name = "${var.prefix}-publish-retry-check-sqs-policy"
role = aws_iam_role.scale_up.name

policy = templatefile("${path.module}/policies/lambda-publish-sqs-policy.json", {
Expand Down
6 changes: 3 additions & 3 deletions modules/runners/ssm-housekeeper.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,15 @@ resource "aws_iam_role" "ssm_housekeeper" {
}

resource "aws_iam_role_policy" "ssm_housekeeper" {
name = "ssm-policy"
name = "${var.prefix}-ssm-policy"
role = aws_iam_role.ssm_housekeeper.name
policy = templatefile("${path.module}/policies/lambda-ssm-housekeeper.json", {
ssm_token_path = "arn:${var.aws_partition}:ssm:${var.aws_region}:${data.aws_caller_identity.current.account_id}:parameter${local.token_path}"
})
}

resource "aws_iam_role_policy" "ssm_housekeeper_logging" {
name = "logging-policy"
name = "${var.prefix}-logging-policy"
role = aws_iam_role.ssm_housekeeper.name
policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.ssm_housekeeper.arn
Expand All @@ -115,7 +115,7 @@ resource "aws_iam_role_policy_attachment" "ssm_housekeeper_vpc_execution_role" {

resource "aws_iam_role_policy" "ssm_housekeeper_xray" {
count = var.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.ssm_housekeeper.name
}
10 changes: 5 additions & 5 deletions modules/webhook/direct/webhook.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ resource "aws_iam_role" "webhook_lambda" {
}

resource "aws_iam_role_policy" "webhook_logging" {
name = "logging-policy"
name = "${var.config.prefix}-logging-policy"
role = aws_iam_role.webhook_lambda.name
policy = templatefile("${path.module}/../policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.webhook.arn
Expand All @@ -112,7 +112,7 @@ resource "aws_iam_role_policy_attachment" "webhook_vpc_execution_role" {
}

resource "aws_iam_role_policy" "webhook_sqs" {
name = "publish-sqs-policy"
name = "${var.config.prefix}-publish-sqs-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-publish-sqs-policy.json", {
Expand All @@ -121,7 +121,7 @@ resource "aws_iam_role_policy" "webhook_sqs" {
}

resource "aws_iam_role_policy" "webhook_kms" {
name = "kms-policy"
name = "${var.config.prefix}-kms-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-kms.json", {
Expand All @@ -130,7 +130,7 @@ resource "aws_iam_role_policy" "webhook_kms" {
}

resource "aws_iam_role_policy" "webhook_ssm" {
name = "publish-ssm-policy"
name = "${var.config.prefix}-publish-ssm-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-ssm.json", {
Expand All @@ -140,7 +140,7 @@ resource "aws_iam_role_policy" "webhook_ssm" {

resource "aws_iam_role_policy" "xray" {
count = var.config.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.config.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.webhook_lambda.name
}
10 changes: 5 additions & 5 deletions modules/webhook/eventbridge/dispatcher.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ resource "aws_iam_role" "dispatcher_lambda" {
}

resource "aws_iam_role_policy" "dispatcher_logging" {
name = "logging-policy"
name = "${var.config.prefix}-logging-policy"
role = aws_iam_role.dispatcher_lambda.name
policy = templatefile("${path.module}/../policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.dispatcher.arn
Expand All @@ -106,7 +106,7 @@ resource "aws_iam_role_policy_attachment" "dispatcher_vpc_execution_role" {
}

resource "aws_iam_role_policy" "dispatcher_sqs" {
name = "publish-sqs-policy"
name = "${var.config.prefix}-publish-sqs-policy"
role = aws_iam_role.dispatcher_lambda.name

policy = templatefile("${path.module}/../policies/lambda-publish-sqs-policy.json", {
Expand All @@ -115,7 +115,7 @@ resource "aws_iam_role_policy" "dispatcher_sqs" {
}

resource "aws_iam_role_policy" "dispatcher_kms" {
name = "kms-policy"
name = "${var.config.prefix}-kms-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-kms.json", {
Expand All @@ -124,7 +124,7 @@ resource "aws_iam_role_policy" "dispatcher_kms" {
}

resource "aws_iam_role_policy" "dispatcher_ssm" {
name = "publish-ssm-policy"
name = "${var.config.prefix}-publish-ssm-policy"
role = aws_iam_role.dispatcher_lambda.name

policy = templatefile("${path.module}/../policies/lambda-ssm.json", {
Expand All @@ -134,7 +134,7 @@ resource "aws_iam_role_policy" "dispatcher_ssm" {

resource "aws_iam_role_policy" "dispatcher_xray" {
count = var.config.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.config.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.dispatcher_lambda.name
}
10 changes: 5 additions & 5 deletions modules/webhook/eventbridge/webhook.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ resource "aws_iam_role" "webhook_lambda" {
}

resource "aws_iam_role_policy" "webhook_logging" {
name = "logging-policy"
name = "${var.config.prefix}-logging-policy"
role = aws_iam_role.webhook_lambda.name
policy = templatefile("${path.module}/../policies/lambda-cloudwatch.json", {
log_group_arn = aws_cloudwatch_log_group.webhook.arn
Expand All @@ -111,7 +111,7 @@ resource "aws_iam_role_policy_attachment" "webhook_vpc_execution_role" {
}

resource "aws_iam_role_policy" "webhook_eventbridge" {
name = "publish-eventbridge-policy"
name = "${var.config.prefix}-publish-eventbridge-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-publish-eventbridge-policy.json", {
Expand All @@ -120,7 +120,7 @@ resource "aws_iam_role_policy" "webhook_eventbridge" {
}

resource "aws_iam_role_policy" "webhook_ssm" {
name = "publish-ssm-policy"
name = "${var.config.prefix}-publish-ssm-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-ssm.json", {
Expand All @@ -129,7 +129,7 @@ resource "aws_iam_role_policy" "webhook_ssm" {
}

resource "aws_iam_role_policy" "webhook_kms" {
name = "kms-policy"
name = "${var.config.prefix}-kms-policy"
role = aws_iam_role.webhook_lambda.name

policy = templatefile("${path.module}/../policies/lambda-kms.json", {
Expand All @@ -139,7 +139,7 @@ resource "aws_iam_role_policy" "webhook_kms" {

resource "aws_iam_role_policy" "xray" {
count = var.config.tracing_config.mode != null ? 1 : 0
name = "xray-policy"
name = "${var.config.prefix}-xray-policy"
policy = data.aws_iam_policy_document.lambda_xray[0].json
role = aws_iam_role.webhook_lambda.name
}
Loading