fix: only tag spot requests if no on-demand fallback

[pwo3]

Hi,

This PR prevents tagging spot instance requests when an on-demand fallback is configured.

It addresses my comment on this issue.

The previous fix was working only if the instance_target_capacity_type is set to on-demand but not in case of on-demand fallback from a spot request.

This approach isn’t ideal but I didn’t find a cleaner way to cancel the tagging directly in lambdas/functions/control-plane/src/aws/runners.ts when the on-demand fallback is triggered.

[r-bk]

@pwo3 @npalm
Any updates on this PR?
Are there any outstanding blockers to merge it?

[npalm]

I will have a look at the PR asap

[npalm]

I have tested the PR, the code was not working do to the falt map was creating duplicated tags and missing describe permission for the lanunch template.

After making some changes the lambda was working. However no tags on the spot request. Changed several things. But did not got it working at all. Really strange, debug showed clearly the correct elements in the TagSpecification.

After updating to main, I got my tag on the spot request back. Maybe we should revert back to the previous approach. And make a not in the terraform code tht this should not be the place but tagging via the spotfleetrequest was not working at all.

[pwo3]

I have tested the PR, the code was not working do to the falt map was creating duplicated tags and missing describe permission for the lanunch template.

After making some changes the lambda was working. However no tags on the spot request. Changed several things. But did not got it working at all. Really strange, debug showed clearly the correct elements in the TagSpecification.

After updating to main, I got my tag on the spot request back. Maybe we should revert back to the previous approach. And make a not in the terraform code tht this should not be the place but tagging via the spotfleetrequest was not working at all.

Thanks for your tests @npalm, too bad it's not working... I reverted to the previous fix and added a comment in the code to explain why we're using this approach

[pwo3]

Hi @npalm, can we merge this PR if everything is OK with you? Thanks

[npalm]

Apply the change to the default example is trigger a change. This bcase the default for enable_on_demand_failover_for_errors is []. Can you include an empty array check in the if.

Sorro for the long response time on the PR