fix: scale down log level #4611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Boissiere <[email protected]>
victorboissiere
force-pushed
the
log-level
branch
from
8c52494 to
7a5abce
Compare
npalm
approved these changes
Jun 12, 2025
|
@stuartp44 added log line could be helpful for you as well. |
|
@victorboissiere CI is failing due to the fact many systems on the net are down, including npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log is very important to check how many instances are being destroyed because idle for a while. This is also consistent with other logs (else conditions). We've lost time because we though this info was present in info but it was not.
This could have helped us understood that ~646 instances were being destroyed in 2 hours timeframe. So making this MR as it could help others too.