Skip to content

fix: scale down log level #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

victorboissiere
Copy link
Contributor

This log is very important to check how many instances are being destroyed because idle for a while. This is also consistent with other logs (else conditions). We've lost time because we though this info was present in info but it was not.

This could have helped us understood that ~646 instances were being destroyed in 2 hours timeframe. So making this MR as it could help others too.

@victorboissiere victorboissiere requested a review from a team as a code owner June 12, 2025 12:29
Signed-off-by: Victor Boissiere <[email protected]>
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorboissiere thx, looks good to me.

@npalm
Copy link
Member

npalm commented Jun 12, 2025

@stuartp44 added log line could be helpful for you as well.

@npalm
Copy link
Member

npalm commented Jun 12, 2025

@victorboissiere CI is failing due to the fact many systems on the net are down, including npm

@npalm npalm merged commit 1d32d26 into github-aws-runners:main Jun 12, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants