-
Notifications
You must be signed in to change notification settings - Fork 693
fix!: remove deprecated terraform variables #4945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes support for deprecated AMI-related variables and fully migrates to the consolidated ami object configuration across all modules. This is a breaking change that simplifies AMI configuration and improves consistency.
Key Changes
- Removed four deprecated AMI variables (
ami_filter,ami_owners,ami_id_ssm_parameter_name,ami_kms_key_arn) from all module interfaces - Updated internal logic to extract SSM parameter names from ARNs when using the
ami.id_ssm_parameter_arnfield - Removed deprecation warning outputs from root and multi-runner modules
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| variables.tf | Removed deprecated AMI variable definitions from root module |
| outputs.tf | Removed deprecation warning output from root module |
| main.tf | Updated runners module call to only pass the ami object |
| modules/runners/variables.tf | Removed deprecated AMI variable definitions from runners module |
| modules/runners/main.tf | Added logic to extract SSM parameter name from ARN and set defaults when ami is null |
| modules/runners/scale-up.tf | Updated to use local.ami_id_ssm_parameter_name instead of variable |
| modules/runners/pool.tf | Updated to use local.ami_id_ssm_parameter_name instead of variable |
| modules/runners/policies-lambda-common.tf | Updated IAM policy to reference local.ami_id_ssm_parameter_name |
| modules/multi-runner/variables.tf | Removed deprecated AMI fields from runner_config object and updated documentation |
| modules/multi-runner/runners.tf | Removed deprecated AMI variable references from module call |
| modules/multi-runner/outputs.tf | Removed deprecation warning output |
| examples/prebuilt/main.tf | Migrated from ami_filter/ami_owners to ami object |
| examples/prebuilt/README.md | Updated documentation examples to use ami object |
| examples/multi-runner/templates/runner-configs/windows-x64.yaml | Migrated AMI filter configuration to ami object structure |
| examples/multi-runner/outputs.tf | Removed deprecation warning output reference |
| examples/ephemeral/main.tf | Updated commented AMI configuration to use ami object |
| examples/default/outputs.tf | Removed deprecation warning output reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Couldn't find any issues besides the configuration change, but that makes sense for a breaking change 👍 |
This pull request removes support for several deprecated AMI-related variables across all modules, fully migrating the configuration to the consolidated
amiobject. This change simplifies how AMI settings are managed, improves consistency, and reduces confusion for users. All references to the old variables (ami_filter,ami_owners,ami_id_ssm_parameter_name,ami_kms_key_arn) have been removed from module inputs, outputs, templates, documentation, and internal logic.Migration to consolidated AMI configuration:
ami_filter,ami_owners,ami_id_ssm_parameter_name,ami_kms_key_arn) from module variable definitions, outputs, and internal usage invariables.tf,outputs.tf, and related files. [1] [2] [3] [4] [5] [6] [7] [8]amiobject structure, replacing previous usage of the deprecated variables. [1] [2] [3] [4] [5]amiobject, removing all fallback and compatibility code for the old variables. [1] [2] [3]With these updates, all AMI configuration is now handled through the unified
amiobject, making runner setup more straightforward and future-proof.Tested