Skip to content

Add listEC2Runners verification to maximum runners test #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuartp44 merged 3 commits into from
Jan 5, 2026
Merged

Add listEC2Runners verification to maximum runners test #4980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152697c
Initial plan
Copilot Jan 5, 2026
3eda8ad
Add listEC2Runners verification to maximum runners test
Copilot Jan 5, 2026
fd5fb28
Use toHaveBeenCalledWith for better consistency
Copilot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ secrets.auto.tfvars

node_modules/
site/
lambdas/package-lock.json
7 changes: 7 additions & 0 deletions lambdas/functions/control-plane/src/scale-runners/scale-up.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,6 +1756,13 @@ describe('Retry mechanism tests', () => {

await scaleUpModule.scaleUp(messages);

// Verify listEC2Runners is called to check current runner count
expect(listEC2Runners).toHaveBeenCalledWith({
environment: 'unit-test-environment',
runnerType: 'Org',
runnerOwner: TEST_DATA_SINGLE.repositoryOwner,
});

// publishRetryMessage should still be called even though no runners will be created
expect(mockPublishRetryMessage).toHaveBeenCalledTimes(2);
expect(createRunner).not.toHaveBeenCalled();
Expand Down
Loading