-
Notifications
You must be signed in to change notification settings - Fork 572
I18n: Korean #1191
base: master
Are you sure you want to change the base?
I18n: Korean #1191
Conversation
config/application.rb
Outdated
|
|
||
| # Available locales | ||
| I18n.available_locales = [:en] | ||
| I18n.available_locales = [:en, :ko] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use %i or %I for an array of symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minwook-shin - Not an error, but code quality standards have been set like this for this project, in the .rubocop.yml file.
So, changing [:en, :ko] -> %i[en ko] would make hound bot happy. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! @athityakumar !
and @houndci-bot , I modified code for you.
|
@tarebyte |
|
@minwook-shin my apologies, I've been super busy and haven't had time to look at this. I'm trying to find someone to validate your translation https://twitter.com/tarebyte/status/919958270550388736 |
|
@tarebyte , okay, I will wait for validating. |
|
I fixed the Korean translation. (some typos) |
|
Did you get someone to verify Korean translation? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
I want to support in internationalization support on your roadmap.
So, I added Korean support.