This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Use assignment creator's token to create repo in certain cases #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricPickup
changed the title
EricPickup
commented
Aug 19, 2019
| is_template: true, | ||
| auto_init: true, | ||
| accept: "application/vnd.github.baptiste-preview" | ||
| auto_init: true |
Contributor
Author
There was a problem hiding this comment.
These changes are unrelated to the PR, just removing un-needed header!
shaunakpp
reviewed
Aug 19, 2019
Contributor
shaunakpp
left a comment
shaunakpp
left a comment
There was a problem hiding this comment.
I've just added a non-blocking comment/enhancement that we could do. Let me know what you think.
EricPickup
force-pushed
the
fix-those-tokens
branch
from
743f3ac to
fc7cf0b
Compare
EricPickup
force-pushed
the
fix-those-tokens
branch
from
fc7cf0b to
b55919e
Compare
Contributor
Author
|
@shaunakpp Sorry for the force-push, but let me know how this looks! |
shaunakpp
approved these changes
Aug 22, 2019
Contributor
Author
|
Closing this and moving to #2286 where there are no unrelated changes/cassettes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Back-end solution to #2222
If the starter code repository is private and does not belong to the classroom organization, use the assignment creator's token to create the student repo.
In all other cases, continue our current method of grabbing a random teachers token to create the students repositories.