Merge branch 'master' into enhancements/using-cache-invalidated-events

Author: StanleyGoldman

docs/contributing/how-to-build.md

@@ -6,7 +6,7 @@ This repository is LFS-enabled. To clone it, you should use a git client that su
 
 ### Windows
 
-- Visual Studio 2015+ or Mono 4.x + bash shell (git bash).
+- Visual Studio 2015+ or [Mono 4.x](https://download.mono-project.com/archive/4.8.1/windows-installer/) + bash shell (git bash).
   - Mono 5.x will not work
 - `UnityEngine.dll` and `UnityEditor.dll`.
   - If you've installed Unity in the default location of `C:\Program Files\Unity` or `C:\Program Files (x86)\Unity`, the build will be able to reference these DLLs automatically. Otherwise, you'll need to copy these DLLs from `[Unity installation path]\Unity\Editor\Data\Managed` into the `lib` directory in order for the build to work
@@ -48,7 +48,7 @@ To build with Visual Studio 2015+, open the solution file `GitHub.Unity.sln`. Se
 
 ### Mono and Bash (windows and mac)
 
-To build with Mono 4.x and Bash execute `build.sh` in a bash shell.
+To build with Mono 4.x and Bash, first ensure Mono is added to PATH. Mono installs to `C:\Program Files\Mono\bin\` by default. Then execute `build.sh` in a bash shell.
 
 ## Build Output
 

src/GitHub.Api/Helpers/Constants.cs

@@ -9,6 +9,7 @@ static class Constants
         public const string UsageFile = "usage.json";
         public const string GitInstallPathKey = "GitInstallPath";
         public const string TraceLoggingKey = "EnableTraceLogging";
+        public const string Iso8601Format = "o";
 
         public static readonly Version MinimumGitVersion = new Version(2, 11, 0);
         public static readonly Version MinimumGitLfsVersion = new Version(2, 3, 4);

src/GitHub.Api/OutputProcessors/LogEntryOutputProcessor.cs

@@ -329,8 +329,8 @@ private void ReturnGitLogEntry()
                     Summary = summary,
                     Description = description,
                     CommitID = commitId,
-                    TimeString = time.Value.ToString(DateTimeFormatInfo.CurrentInfo),
-                    CommitTimeString = committerTime.Value.ToString(DateTimeFormatInfo.CurrentInfo)
+                    TimeString = time.Value.ToString(Constants.Iso8601Format),
+                    CommitTimeString = committerTime.Value.ToString(Constants.Iso8601Format)
                 });
             }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
-using Octokit;
 using UnityEditor;
 using UnityEngine;
 using Application = UnityEngine.Application;
@@ -183,14 +183,22 @@ public DateTimeOffset LastUpdatedAt
             {
                 if (!lastUpdatedAtValue.HasValue)
                 {
-                    lastUpdatedAtValue = DateTimeOffset.Parse(LastUpdatedAtString);
+                    DateTimeOffset result;
+                    if (DateTimeOffset.TryParseExact(LastUpdatedAtString, Constants.Iso8601Format, CultureInfo.InvariantCulture, DateTimeStyles.None, out result))
+                    {
+                        lastUpdatedAtValue = result;
+                    }
+                    else
+                    {
+                        lastUpdatedAtValue = DateTimeOffset.MinValue;
+                    }
                 }
 
                 return lastUpdatedAtValue.Value;
             }
             set
             {
-                LastUpdatedAtString = value.ToString();
+                LastUpdatedAtString = value.ToString(Constants.Iso8601Format);
                 lastUpdatedAtValue = null;
             }
         }
@@ -201,14 +209,22 @@ public DateTimeOffset LastVerifiedAt
             {
                 if (!lastVerifiedAtValue.HasValue)
                 {
-                    lastVerifiedAtValue = DateTimeOffset.Parse(LastVerifiedAtString);
+                    DateTimeOffset result;
+                    if (DateTimeOffset.TryParseExact(LastVerifiedAtString, Constants.Iso8601Format, CultureInfo.InvariantCulture, DateTimeStyles.None, out result))
+                    {
+                        lastVerifiedAtValue = result;
+                    }
+                    else
+                    {
+                        lastVerifiedAtValue = DateTimeOffset.MinValue;
+                    }
                 }
 
                 return lastVerifiedAtValue.Value;
             }
             set
             {
-                LastVerifiedAtString = value.ToString();
+                LastVerifiedAtString = value.ToString(Constants.Iso8601Format);
                 lastVerifiedAtValue = null;
             }
         }

src/tests/IntegrationTests/Process/ProcessManagerIntegrationTests.cs

@@ -57,8 +57,8 @@ public async Task LogEntriesTest()
                     CommitID = "018997938335742f8be694240a7c2b352ec0835f",
                     Description = "Moving project files where they should be kept",
                     Summary = "Moving project files where they should be kept",
-                    TimeString = firstCommitTime.ToString(DateTimeFormatInfo.CurrentInfo),
-                    CommitTimeString = firstCommitTime.ToString(DateTimeFormatInfo.CurrentInfo),
+                    TimeString = firstCommitTime.ToString(Constants.Iso8601Format),
+                    CommitTimeString = firstCommitTime.ToString(Constants.Iso8601Format),
                 },
                 new GitLogEntry
                 {
@@ -75,8 +75,8 @@ public async Task LogEntriesTest()
                     CommitID = "03939ffb3eb8486dba0259b43db00842bbe6eca1",
                     Description = "Initial Commit",
                     Summary = "Initial Commit",
-                    TimeString = secondCommitTime.ToString(DateTimeFormatInfo.CurrentInfo),
-                    CommitTimeString = secondCommitTime.ToString(DateTimeFormatInfo.CurrentInfo),
+                    TimeString = secondCommitTime.ToString(Constants.Iso8601Format),
+                    CommitTimeString = secondCommitTime.ToString(Constants.Iso8601Format),
                 },
             });
         }
@@ -110,8 +110,8 @@ public async Task RussianLogEntriesTest()
                     CommitID = "06d6451d351626894a30e9134f551db12c74254b",
                     Description = "Я люблю github",
                     Summary = "Я люблю github",
-                    TimeString = commitTime.ToString(DateTimeFormatInfo.CurrentInfo),
-                    CommitTimeString = commitTime.ToString(DateTimeFormatInfo.CurrentInfo),
+                    TimeString = commitTime.ToString(Constants.Iso8601Format),
+                    CommitTimeString = commitTime.ToString(Constants.Iso8601Format),
                 }
             });
         }

src/tests/UnitTests/IO/LogEntryOutputProcessorTests.cs

@@ -58,8 +58,8 @@ public void ShouldParseSingleCommit()
                     },
                     Summary = "Rename RepositoryModelBase to RepositoryModel",
                     Description = "Rename RepositoryModelBase to RepositoryModel",
-                    TimeString = commitTime.ToString(DateTimeFormatInfo.CurrentInfo),
-                    CommitTimeString = commitTime.ToString(DateTimeFormatInfo.CurrentInfo),
+                    TimeString = commitTime.ToString(Constants.Iso8601Format),
+                    CommitTimeString = commitTime.ToString(Constants.Iso8601Format),
                 },
             };