Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 154a687

Browse files
shanashana
committed
Disable code analysis in the dev configuration, it's sloooow
1 parent df58256 commit 154a687

File tree

5 files changed

+34
-9
lines changed

5 files changed

+34
-9
lines changed

‎common/codeanalysis-debug.ruleset

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@
111111
<Rule Id="CA2229" Action="None" />
112112
<Rule Id="CA2240" Action="None" />
113113

114+
<!-- the compiler already warns about this -->
115+
<Rule Id="CA1823" Action="None" />
116+
114117
</Rules>
115118
<Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
116119
<Rule Id="IDE0001" Action="None" />

‎common/codeanalysis-release.ruleset

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@
9999
<!-- Unity does its own serialization and doesn't need special serializable type constructors -->
100100
<Rule Id="CA2229" Action="None" />
101101
<Rule Id="CA2240" Action="None" />
102+
103+
<!-- the compiler already warns about this -->
104+
<Rule Id="CA1823" Action="None" />
102105
</Rules>
103106
<Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
104107
<Rule Id="IDE0001" Action="None" />

‎src/GitHub.Api/GitHub.Api.csproj

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<NuGetPackageImportStamp>
1818
</NuGetPackageImportStamp>
1919
<OutputPath>..\UnityExtension\Assets\Editor\build\</OutputPath>
20-
<RunCodeAnalysis>true</RunCodeAnalysis>
21-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
22-
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2320
</PropertyGroup>
2421
<Import Project="..\..\common\properties.props" />
2522
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -29,6 +26,9 @@
2926
<DefineConstants>DEBUG;TRACE</DefineConstants>
3027
<ErrorReport>prompt</ErrorReport>
3128
<WarningLevel>4</WarningLevel>
29+
<RunCodeAnalysis>true</RunCodeAnalysis>
30+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
31+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3232
</PropertyGroup>
3333
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
3434
<DebugType>pdbonly</DebugType>
@@ -37,6 +37,9 @@
3737
<ErrorReport>prompt</ErrorReport>
3838
<WarningLevel>4</WarningLevel>
3939
<BuildConfid>Release</BuildConfid>
40+
<RunCodeAnalysis>true</RunCodeAnalysis>
41+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
42+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
4043
</PropertyGroup>
4144
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'dev|AnyCPU'">
4245
<DebugSymbols>true</DebugSymbols>
@@ -45,6 +48,9 @@
4548
<DefineConstants>TRACE;DEBUG;DEVELOPER_BUILD</DefineConstants>
4649
<ErrorReport>prompt</ErrorReport>
4750
<WarningLevel>4</WarningLevel>
51+
<RunCodeAnalysis>false</RunCodeAnalysis>
52+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
53+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
4854
</PropertyGroup>
4955
<PropertyGroup>
5056
<BuildConfig Condition=" '$(BuildConfig)' == '' ">Debug</BuildConfig>

‎src/GitHub.Logging/GitHub.Logging.csproj

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
<TargetFrameworkVersion>v3.5</TargetFrameworkVersion>
1313
<FileAlignment>512</FileAlignment>
1414
<OutputPath>..\UnityExtension\Assets\Editor\build\</OutputPath>
15-
<RunCodeAnalysis>true</RunCodeAnalysis>
16-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
17-
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
1815
</PropertyGroup>
1916
<Import Project="..\..\common\properties.props" />
2017
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -24,6 +21,9 @@
2421
<Optimize>false</Optimize>
2522
<DefineConstants>DEBUG;TRACE</DefineConstants>
2623
<ErrorReport>prompt</ErrorReport>
24+
<RunCodeAnalysis>true</RunCodeAnalysis>
25+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
26+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2727
</PropertyGroup>
2828
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
2929
<PlatformTarget>AnyCPU</PlatformTarget>
@@ -32,6 +32,9 @@
3232
<DefineConstants>TRACE</DefineConstants>
3333
<ErrorReport>prompt</ErrorReport>
3434
<WarningLevel>4</WarningLevel>
35+
<RunCodeAnalysis>true</RunCodeAnalysis>
36+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
37+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3538
</PropertyGroup>
3639
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'dev|AnyCPU'">
3740
<PlatformTarget>AnyCPU</PlatformTarget>
@@ -40,6 +43,9 @@
4043
<Optimize>false</Optimize>
4144
<DefineConstants>DEBUG;TRACE;DEVELOPER_BUILD</DefineConstants>
4245
<ErrorReport>prompt</ErrorReport>
46+
<RunCodeAnalysis>false</RunCodeAnalysis>
47+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
48+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
4349
</PropertyGroup>
4450
<PropertyGroup>
4551
<BuildConfig Condition=" '$(BuildConfig)' == '' ">Debug</BuildConfig>

‎src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
<FileAlignment>512</FileAlignment>
1414
<OutputPath>$(SolutionDir)\unity\TestProject\Assets\Plugins\GitHub\Editor\</OutputPath>
1515
<IntermediateOutputPath>..\..\..\obj\</IntermediateOutputPath>
16-
<RunCodeAnalysis>true</RunCodeAnalysis>
17-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
18-
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
1916
</PropertyGroup>
2017
<Import Project="..\..\..\..\..\common\properties.props" />
2118
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -26,14 +23,21 @@
2623
<ErrorReport>prompt</ErrorReport>
2724
<WarningLevel>4</WarningLevel>
2825
<LangVersion>4</LangVersion>
26+
<RunCodeAnalysis>true</RunCodeAnalysis>
27+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
28+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2929
</PropertyGroup>
3030
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
3131
<DebugType>pdbonly</DebugType>
3232
<Optimize>true</Optimize>
3333
<DefineConstants>TRACE</DefineConstants>
3434
<ErrorReport>prompt</ErrorReport>
3535
<WarningLevel>4</WarningLevel>
36+
<LangVersion>4</LangVersion>
3637
<BuildConfid>Release</BuildConfid>
38+
<RunCodeAnalysis>true</RunCodeAnalysis>
39+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
40+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3741
</PropertyGroup>
3842
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'dev|AnyCPU'">
3943
<DebugSymbols>true</DebugSymbols>
@@ -43,6 +47,9 @@
4347
<ErrorReport>prompt</ErrorReport>
4448
<WarningLevel>4</WarningLevel>
4549
<LangVersion>4</LangVersion>
50+
<RunCodeAnalysis>false</RunCodeAnalysis>
51+
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
52+
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
4653
</PropertyGroup>
4754
<ItemGroup>
4855
<Reference Include="Mono.Security, Version=2.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756, processorArchitecture=MSIL">

0 commit comments

Comments
 (0)