Fixing a ton of stuff

Author: CapnRat

src/GitHub.Api/Installer/GitInstaller.cs

@@ -29,7 +29,7 @@ public ITask<NPath> SetupGitIfNeeded()
         {
             //Logger.Trace("SetupGitIfNeeded");
 
-            installationTask = new FuncTask<GitInstallationState, NPath>(cancellationToken, (_, r) => installDetails.GitExecutablePath)
+            installationTask = new FuncTask<NPath>(cancellationToken, (_) => installDetails.GitExecutablePath)
                 { Name = "Git Installation - Complete" };
             installationTask.OnStart += thisTask => thisTask.UpdateProgress(0, 100);
             installationTask.OnEnd += (thisTask, result, success, exception) => thisTask.UpdateProgress(100, 100);

src/GitHub.Api/Installer/UnzipTask.cs

@@ -71,21 +71,22 @@ protected virtual NPath RunUnzip(bool success)
                             UpdateProgress(value, total);
                             return !Token.IsCancellationRequested;
                         });
-
+/*
                     if (expectedMD5 != null)
                     {
                         var calculatedMD5 = fileSystem.CalculateFolderMD5(extractedPath);
                         success = calculatedMD5.Equals(expectedMD5, StringComparison.InvariantCultureIgnoreCase);
+*/
                         if (!success)
                         {
                             extractedPath.DeleteIfExists();
 
-                            var message = $"Extracted MD5: {calculatedMD5} Does not match expected: {expectedMD5}";
-                            Logger.Error(message);
+                            //var message = $"Extracted MD5: {calculatedMD5} Does not match expected: {expectedMD5}";
+                            var message = $"Failed to extract {archiveFilePath} to {extractedPath}";
 
                             exception = new UnzipException(message);
                         }
-                    }
+//                    }
                 }
                 catch (Exception ex)
                 {

src/GitHub.Api/OutputProcessors/ProcessManager.cs

@@ -84,7 +84,7 @@ public void RunCommandLineWindow(NPath workingDirectory)
                 var envVars = startInfo.EnvironmentVariables;
                 var scriptContents = new[] {
                     $"cd {envVars["GHU_WORKINGDIR"]}",
-                    $"PATH={envVars["GHU_FULLPATH"]}:$PATH /bin/bash"
+                    $"PATH=\"{envVars["GHU_FULLPATH"]}\":$PATH /bin/bash"
                 };
                 environment.FileSystem.WriteAllLines(envVarFile, scriptContents);
                 Mono.Unix.Native.Syscall.chmod(envVarFile, (Mono.Unix.Native.FilePermissions)493); // -rwxr-xr-x mode (0755)

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

@@ -166,7 +166,7 @@ private void MaybeUpdateData()
         {
             if (metricsHasChanged)
             {
-                metricsEnabled = Manager.UsageTracker.Enabled;
+                //metricsEnabled = Manager.UsageTracker.Enabled;
                 metricsHasChanged = false;
             }