Merge pull request #495 from github-for-unity/fixes/default-struct-null-check

StanleyGoldman · web-flow · commit 4796f996f146 · 2017-12-04T11:51:39.000-05:00
Correctly returning null when the value is default
diff --git a/src/GitHub.Api/Git/GitConfig.cs b/src/GitHub.Api/Git/GitConfig.cs
@@ -50,11 +50,11 @@ public ConfigBranch(string name, ConfigRemote? remote)
             this.remote = remote ?? ConfigRemote.Default;
         }
 
-        public bool IsTracking => !remote.Equals(ConfigRemote.Default);
+        public bool IsTracking => Remote.HasValue;
 
         public string Name => name;
 
-        public ConfigRemote? Remote => remote;
+        public ConfigRemote? Remote => Equals(remote, ConfigRemote.Default) ? (ConfigRemote?) null : remote;
 
         public override string ToString()
         {

Original file line number	Diff line number	Diff line change
`@@ -50,11 +50,11 @@ public ConfigBranch(string name, ConfigRemote? remote)`
`50`	`50`	`this.remote = remote ?? ConfigRemote.Default;`
`51`	`51`	`}`
`52`	`52`
`53`		`- public bool IsTracking => !remote.Equals(ConfigRemote.Default);`
	`53`	`+ public bool IsTracking => Remote.HasValue;`
`54`	`54`
`55`	`55`	`public string Name => name;`
`56`	`56`
`57`		`- public ConfigRemote? Remote => remote;`
	`57`	`+ public ConfigRemote? Remote => Equals(remote, ConfigRemote.Default) ? (ConfigRemote?) null : remote;`
`58`	`58`
`59`	`59`	`public override string ToString()`
`60`	`60`	`{`