We can't do an md5 folder check after unzipping, it's not going to be deterministic

OSes will write stuff to disk which will change the md5 sum

Author: shana

src/GitHub.Api/Installer/GitInstaller.cs

@@ -146,7 +146,7 @@ private FuncTask<NPath> ExtractPortableGit(GitInstallationState state)
             if (!state.GitIsValid)
             {
                 ITask<NPath> unzipTask = new UnzipTask(cancellationToken, installDetails.GitZipPath, gitExtractPath, sharpZipLibHelper,
-                    environment.FileSystem, GitInstallDetails.GitExtractedMD5);
+                    environment.FileSystem);
                 unzipTask.Progress(p => installationTask.UpdateProgress(40 + (long)(20 * p.Percentage), 100, unzipTask.Name));
 
                 unzipTask = unzipTask.Then((s, path) =>
@@ -169,7 +169,7 @@ private FuncTask<NPath> ExtractPortableGit(GitInstallationState state)
             if (!state.GitLfsIsValid)
             {
                 ITask<NPath> unzipTask = new UnzipTask(cancellationToken, installDetails.GitLfsZipPath, gitLfsExtractPath, sharpZipLibHelper,
-                    environment.FileSystem, GitInstallDetails.GitLfsExtractedMD5);
+                    environment.FileSystem);
                 unzipTask.Progress(p => installationTask.UpdateProgress(60 + (long)(20 * p.Percentage), 100, unzipTask.Name));
 
                 unzipTask = unzipTask.Then((s, path) =>

src/GitHub.Api/Installer/OctorunInstaller.cs

@@ -45,7 +45,7 @@ public ITask<NPath> SetupOctorunIfNeeded()
                     var tempZipExtractPath = NPath.CreateTempDirectory("octorun_extract_archive_path");
                     var unzipTask = new UnzipTask(taskManager.Token, installDetails.ZipFile,
                             tempZipExtractPath, sharpZipLibHelper,
-                            fileSystem, OctorunInstallDetails.ExtractedMD5)
+                            fileSystem)
                         .Then((success, p) => MoveOctorun(p));
                     t.Then(unzipTask);
                 }

src/GitHub.Api/Installer/UnzipTask.cs

@@ -12,14 +12,13 @@ class UnzipTask : TaskBase<NPath>
         private readonly string expectedMD5;
 
         public UnzipTask(CancellationToken token, NPath archiveFilePath, NPath extractedPath,
-            IZipHelper zipHelper, IFileSystem fileSystem, string expectedMD5)
+            IZipHelper zipHelper, IFileSystem fileSystem)
             : base(token)
         {
             this.archiveFilePath = archiveFilePath;
             this.extractedPath = extractedPath;
             this.zipHelper = zipHelper;
             this.fileSystem = fileSystem;
-            this.expectedMD5 = expectedMD5;
             Name = $"Unzip {archiveFilePath.FileName}";
         }
 
@@ -71,22 +70,14 @@ protected virtual NPath RunUnzip(bool success)
                             UpdateProgress(value, total);
                             return !Token.IsCancellationRequested;
                         });
-/*
-                    if (expectedMD5 != null)
-                    {
-                        var calculatedMD5 = fileSystem.CalculateFolderMD5(extractedPath);
-                        success = calculatedMD5.Equals(expectedMD5, StringComparison.InvariantCultureIgnoreCase);
-*/
-                        if (!success)
-                        {
-                            extractedPath.DeleteIfExists();
 
-                            //var message = $"Extracted MD5: {calculatedMD5} Does not match expected: {expectedMD5}";
-                            var message = $"Failed to extract {archiveFilePath} to {extractedPath}";
+                    if (!success)
+                    {
+                        extractedPath.DeleteIfExists();
 
-                            exception = new UnzipException(message);
-                        }
-//                    }
+                        var message = $"Failed to extract {archiveFilePath} to {extractedPath}";
+                        exception = new UnzipException(message);
+                    }
                 }
                 catch (Exception ex)
                 {

src/tests/IntegrationTests/UnzipTaskTests.cs

@@ -27,7 +27,7 @@ public async Task UnzipWorks()
 
             var unzipTask = new UnzipTask(CancellationToken.None, archiveFilePath, extractedPath,
                     ZipHelper.Instance,
-                    Environment.FileSystem, GitInstaller.GitInstallDetails.GitLfsExtractedMD5)
+                    Environment.FileSystem)
                 .Progress(p => 
                 {
                 });
@@ -51,7 +51,7 @@ public void FailsWhenMD5Incorrect()
             var extractedPath = TestBasePath.Combine("gitlfs_zip_extracted").CreateDirectory();
 
             var unzipTask = new UnzipTask(CancellationToken.None, archiveFilePath, extractedPath, 
-                ZipHelper.Instance, Environment.FileSystem, "AABBCCDD");
+                ZipHelper.Instance, Environment.FileSystem);
 
             Assert.Throws<UnzipException>(async () => await unzipTask.StartAwait());