Fix building without access to internal stuff

Author: shana

common/properties.props

@@ -3,6 +3,7 @@
   <!-- Build flags -->
   <PropertyGroup>
     <BuildType Condition="Exists('$(SolutionDir)script\src\MetricsService.cs')">Internal</BuildType>
+    <BuildDefs Condition="Exists('$(SolutionDir)script\src\MetricsService.cs')">ENABLE_METRICS</BuildDefs>
 
     <UnityDir Condition="$(UnityDir) == '' and Exists('$(SolutionDir)\script\lib\UnityEditor.dll')">$(SolutionDir)\script\lib\</UnityDir>
     <UnityDir Condition="$(UnityDir) == '' and Exists('$(SolutionDir)\lib\UnityEditor.dll')">$(SolutionDir)\lib\</UnityDir>

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -174,7 +174,8 @@ protected void SetupMetrics(string unityVersion, bool firstRun)
                 id = Guid.NewGuid().ToString();
                 UserSettings.Set(Constants.GuidKey, id);
             }
-/*
+
+#if ENABLE_METRICS
             var metricsService = new MetricsService(ProcessManager,
                 TaskManager,
                 Environment.FileSystem,
@@ -187,7 +188,7 @@ protected void SetupMetrics(string unityVersion, bool firstRun)
             {
                 UsageTracker.IncrementLaunchCount();
             }
-*/
+#endif
         }
 
         protected abstract void SetupMetrics();

src/GitHub.Api/GitHub.Api.csproj

@@ -22,7 +22,7 @@
     <DebugSymbols>true</DebugSymbols>
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
-    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <DefineConstants>DEBUG;TRACE;$(BuildDefs)</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <RunCodeAnalysis>true</RunCodeAnalysis>
@@ -32,7 +32,7 @@
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
-    <DefineConstants>TRACE</DefineConstants>
+    <DefineConstants>TRACE;$(BuildDefs)</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <BuildConfid>Release</BuildConfid>
@@ -44,7 +44,7 @@
     <DebugSymbols>true</DebugSymbols>
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
-    <DefineConstants>TRACE;DEBUG;DEVELOPER_BUILD</DefineConstants>
+    <DefineConstants>TRACE;DEBUG;DEVELOPER_BUILD;$(BuildDefs)</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <RunCodeAnalysis>false</RunCodeAnalysis>

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

@@ -166,7 +166,7 @@ private void MaybeUpdateData()
         {
             if (metricsHasChanged)
             {
-                //metricsEnabled = Manager.UsageTracker.Enabled;
+                metricsEnabled = Manager.UsageTracker != null ? Manager.UsageTracker.Enabled : false;
                 metricsHasChanged = false;
             }
 
@@ -311,7 +311,7 @@ private void OnPrivacyGui()
         {
             GUILayout.Label(PrivacyTitle, EditorStyles.boldLabel);
 
-            EditorGUI.BeginDisabledGroup(IsBusy);
+            EditorGUI.BeginDisabledGroup(IsBusy && Manager.UsageTracker != null);
             {
 
                 EditorGUI.BeginChangeCheck();
@@ -320,7 +320,8 @@ private void OnPrivacyGui()
                 }
                 if (EditorGUI.EndChangeCheck())
                 {
-                    Manager.UsageTracker.Enabled = metricsEnabled;
+                    if (Manager.UsageTracker != null)
+                        Manager.UsageTracker.Enabled = metricsEnabled;
                 }
             }
             EditorGUI.EndDisabledGroup();