Merge pull request #818 from github-for-unity/fixes/fix-checking-version-of-octorun-doh

StanleyGoldman · web-flow · commit 833acffb4ad4 · 2018-06-01T13:26:02.000-04:00
Fix octorun version check sigh
diff --git a/src/GitHub.Api/Installer/OctorunInstaller.cs b/src/GitHub.Api/Installer/OctorunInstaller.cs
@@ -71,7 +71,7 @@ private bool IsOctorunExtracted()
                 return false;
             }
 
-            var octorunVersion = installDetails.VersionFile.ReadAllText();
+            var octorunVersion = installDetails.VersionFile.ReadAllText().Trim();
             if (!OctorunInstallDetails.PackageVersion.Equals(octorunVersion))
             {
                 Logger.Warning("Current version {0} does not match expected {1}", octorunVersion, OctorunInstallDetails.PackageVersion);

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ private bool IsOctorunExtracted()`
`71`	`71`	`return false;`
`72`	`72`	`}`
`73`	`73`
`74`		`- var octorunVersion = installDetails.VersionFile.ReadAllText();`
	`74`	`+ var octorunVersion = installDetails.VersionFile.ReadAllText().Trim();`
`75`	`75`	`if (!OctorunInstallDetails.PackageVersion.Equals(octorunVersion))`
`76`	`76`	`{`
`77`	`77`	`Logger.Warning("Current version {0} does not match expected {1}", octorunVersion, OctorunInstallDetails.PackageVersion);`