Merge branch 'fixes/task-base-null-fix' into enhancements/git-setup-download

StanleyGoldman · StanleyGoldman · commit 8f7e1a19d9c2 · 2018-01-02T17:15:19.000-05:00
diff --git a/src/GitHub.Api/Tasks/TaskBase.cs b/src/GitHub.Api/Tasks/TaskBase.cs
@@ -597,7 +597,7 @@ public TaskBase(CancellationToken token)
         {
             Task = new Task<TResult>(() =>
             {
-                var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, DependsOn.Successful ? ((ITask<T>)DependsOn).Result : default(T));
+                var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, (DependsOn?.Successful ?? false) ? ((ITask<T>)DependsOn).Result : default(T));
                 tcs.SetResult(ret);
                 AdjustNextTask(ret);
                 return ret;

Original file line number	Diff line number	Diff line change
`@@ -597,7 +597,7 @@ public TaskBase(CancellationToken token)`
`597`	`597`	`{`
`598`	`598`	`Task = new Task<TResult>(() =>`
`599`	`599`	`{`
`600`		`- var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, DependsOn.Successful ? ((ITask<T>)DependsOn).Result : default(T));`
	`600`	`+ var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, (DependsOn?.Successful ?? false) ? ((ITask<T>)DependsOn).Result : default(T));`
`601`	`601`	`tcs.SetResult(ret);`
`602`	`602`	`AdjustNextTask(ret);`
`603`	`603`	`return ret;`