Merge more-serialization-magic into fixes/metrics-rename

Author: shana

src/GitHub.Api/Helpers/SimpleJson.cs

@@ -1252,9 +1252,9 @@ class PocoJsonSerializerStrategy : IJsonSerializerStrategy
 
         private static readonly string[] Iso8601Format = new string[]
                                                              {
+                                                                @"yyyy-MM-dd\THH\:mm\:sszzz",
                                                                 @"yyyy-MM-dd\THH\:mm\:ss.fffffffzzz",
                                                                 @"yyyy-MM-dd\THH\:mm\:ss.fffzzz",
-                                                                @"yyyy-MM-dd\THH\:mm\:sszzz",
                                                                 @"yyyy-MM-dd\THH:mm:ss.fffffffzzz",
                                                                 @"yyyy-MM-dd\THH:mm:ss.fffzzz",
                                                                 @"yyyy-MM-dd\THH:mm:sszzz",
@@ -1274,7 +1274,7 @@ protected virtual string MapClrMemberNameToJsonFieldName(string clrPropertyName)
 
         internal virtual ReflectionUtils.ConstructorDelegate ContructorDelegateFactory(Type key)
         {
-            return ReflectionUtils.GetContructor(key, key.IsArray ? ArrayConstructorParameterTypes : EmptyTypes);
+            return ReflectionUtils.GetContructor(key, (key.IsArray || ReflectionUtils.IsAssignableFrom(typeof(IList), key))? ArrayConstructorParameterTypes : EmptyTypes);
         }
 
         internal virtual IDictionary<string, ReflectionUtils.GetDelegate> GetterValueFactory(Type type)

src/tests/UnitTests/Primitives/SerializationTests.cs

@@ -30,5 +30,20 @@ public void DateTimeSerializationRoundTrip()
             Assert.AreEqual(dt1, dt2);
             Assert.AreEqual(dt2, dt3);
         }
+
+        class TestData
+        {
+            public List<string> Things { get; set; } = new List<string>();
+        }
+
+        [Test]
+        public void ListDeserializesCorrectly()
+        {
+            var data = new TestData();
+            data.Things.Add("something");
+            var json = data.ToJson();
+            var ret = json.FromJson<TestData>();
+            CollectionAssert.AreEquivalent(data.Things, ret.Things);
+        }
     }
 }