Add spaces to pahts in tests so we can catch potential problems

Author: shana

src/GitHub.Api/Application/ApplicationInfo.cs

@@ -4,7 +4,7 @@ namespace GitHub.Unity
     static partial class ApplicationInfo
     {
 #if DEBUG
-        public const string ApplicationName = "GitHubUnityDebug";
+        public const string ApplicationName = "GitHub for Unity Debug";
         public const string ApplicationProvider = "GitHub";
 #else
         public const string ApplicationName = "GitHubUnity";

src/tests/IntegrationTests/BaseIntegrationTest.cs

@@ -158,13 +158,16 @@ protected void SetupGit(NPath pathToSetupGitInto, string testName)
             Exception ex = null;
 
             var setupTask = gitInstaller.SetupGitIfNeeded();
-            setupTask.OnEnd += (thisTask, path, success, exception) => {
-                result = path;
-                ex = exception;
-                autoResetEvent.Set();
+            setupTask.OnEnd += (thisTask, _, __, ___) => {
+                ((ITask<NPath>)thisTask.GetEndOfChain()).OnEnd += (t, path, success, exception) =>
+                {
+                    result = path;
+                    ex = exception;
+                    autoResetEvent.Set();
+                };
             };
-
-            if (!autoResetEvent.WaitOne(TimeSpan.FromMinutes(1)))
+            setupTask.Start();
+            if (!autoResetEvent.WaitOne(TimeSpan.FromMinutes(5)))
                 throw new TimeoutException($"Test setup unzipping {zipArchivesPath} to {pathToSetupGitInto} timed out");
 
             if (result == null)
@@ -197,7 +200,7 @@ public virtual void TestFixtureTearDown()
         [SetUp]
         public virtual void OnSetup()
         {
-            TestBasePath = NPath.CreateTempDirectory("integration-tests");
+            TestBasePath = NPath.CreateTempDirectory("integration tests");
             NPath.FileSystem.SetCurrentDirectory(TestBasePath);
             TestRepoMasterCleanUnsynchronized = TestBasePath.Combine("IOTestsRepo", "IOTestsRepo_master_clean_unsync");
             TestRepoMasterCleanUnsynchronizedRussianLanguage = TestBasePath.Combine("IOTestsRepo", "IOTestsRepo_master_clean_sync_with_russian_language");

src/tests/IntegrationTests/IntegrationTestEnvironment.cs

@@ -12,8 +12,6 @@ class IntegrationTestEnvironment : IEnvironment
         private static readonly ILogging logger = LogHelper.GetLogger<IntegrationTestEnvironment>();
         private readonly bool enableTrace;
 
-        private readonly NPath integrationTestEnvironmentPath;
-
         private DefaultEnvironment defaultEnvironment;
 
         public IntegrationTestEnvironment(ICacheContainer cacheContainer,
@@ -26,13 +24,10 @@ public IntegrationTestEnvironment(ICacheContainer cacheContainer,
             defaultEnvironment = new DefaultEnvironment(cacheContainer);
             defaultEnvironment.FileSystem.SetCurrentDirectory(repoPath);
             environmentPath = environmentPath ??
-                defaultEnvironment.GetSpecialFolder(Environment.SpecialFolder.LocalApplicationData)
-                                  .ToNPath()
-                                  .EnsureDirectoryExists(ApplicationInfo.ApplicationName + "-IntegrationTests");
+                defaultEnvironment.UserCachePath.EnsureDirectoryExists("IntegrationTests");
 
-            integrationTestEnvironmentPath = environmentPath.Value;
-            UserCachePath = integrationTestEnvironmentPath.Combine("User");
-            SystemCachePath = integrationTestEnvironmentPath.Combine("System");
+            UserCachePath = environmentPath.Value.Combine("User");
+            SystemCachePath = environmentPath.Value.Combine("System");
 
             var installPath = solutionDirectory.Parent.Parent.Combine("src", "GitHub.Api");
 
@@ -76,7 +71,7 @@ public string GetEnvironmentVariable(string v)
 
         public string GetSpecialFolder(Environment.SpecialFolder folder)
         {
-            var ensureDirectoryExists = integrationTestEnvironmentPath.EnsureDirectoryExists(folder.ToString());
+            var ensureDirectoryExists = UserCachePath.Parent.EnsureDirectoryExists(folder.ToString());
             var specialFolderPath = ensureDirectoryExists.ToString();
 
             if (enableTrace)
@@ -87,7 +82,7 @@ public string GetSpecialFolder(Environment.SpecialFolder folder)
             return specialFolderPath;
         }
 
-        public string UserProfilePath => integrationTestEnvironmentPath.CreateDirectory("user-profile-path");
+        public string UserProfilePath => UserCachePath.Parent.CreateDirectory("user profile path");
 
         public NPath Path => Environment.GetEnvironmentVariable("PATH").ToNPath();
         public string NewLine => Environment.NewLine;

src/tests/TaskSystemIntegrationTests/Tests.cs

@@ -43,7 +43,7 @@ public void OneTimeSetup()
             TaskManager.UIScheduler = new SynchronizationContextTaskScheduler(syncContext);
 
             var env = new DefaultEnvironment();
-            TestBasePath = NPath.CreateTempDirectory("integration-tests");
+            TestBasePath = NPath.CreateTempDirectory("integration tests");
             env.FileSystem.SetCurrentDirectory(TestBasePath);
 
             var repo = Substitute.For<IRepository>();