String comparison fixes

Author: shana

src/GitHub.Api/IO/NiceIO.cs

@@ -464,8 +464,8 @@ public int CompareTo(object obj)
 
         public bool HasExtension(params string[] extensions)
         {
-            var extensionWithDotLower = ExtensionWithDot.ToLower(CultureInfo.InvariantCulture);
-            return extensions.Any(e => WithDot(e).ToLower(CultureInfo.InvariantCulture) == extensionWithDotLower);
+            var extensionWithDotLower = ExtensionWithDot.ToUpperInvariant();
+            return extensions.Any(e => WithDot(e).ToUpperInvariant() == extensionWithDotLower);
         }
 
         private static string WithDot(string extension)

src/GitHub.Api/Installer/GitInstaller.cs

@@ -99,7 +99,7 @@ public bool IsGitLfsExtracted()
             var calculateMd5 = environment.FileSystem.CalculateMD5(GitLfsExecutablePath);
             logger.Trace("GitLFS MD5: {0}", calculateMd5);
             var md5 = environment.IsWindows ? WindowsGitLfsExecutableMD5 : MacGitLfsExecutableMD5;
-            if (md5.Equals(calculateMd5, StringComparison.InvariantCultureIgnoreCase))
+            if (md5.Equals(calculateMd5, StringComparison.OrdinalIgnoreCase))
             {
                 logger.Trace("{0} has incorrect MD5", GitExecutablePath);
                 return false;

src/GitHub.Api/OutputProcessors/LogEntryOutputProcessor.cs

@@ -135,7 +135,7 @@ public override void LineReceived(string line)
 
                 case ProcessingPhase.Summary:
                     {
-                        var idx = line.IndexOf("---GHUBODYEND---", StringComparison.InvariantCulture);
+                        var idx = line.IndexOf("---GHUBODYEND---", StringComparison.Ordinal);
                         var oneliner = idx >= 0;
                         if (oneliner)
                         {

src/GitHub.Api/OutputProcessors/RemoteListOutputProcessor.cs

@@ -56,10 +56,10 @@ public override void LineReceived(string line)
 
         private void ReturnRemote()
         {
-            var modes = currentModes.Select(s => s.ToLowerInvariant()).ToArray();
+            var modes = currentModes.Select(s => s.ToUpperInvariant()).ToArray();
 
-            var isFetch = modes.Contains("fetch");
-            var isPush = modes.Contains("push");
+            var isFetch = modes.Contains("FETCH");
+            var isPush = modes.Contains("PUSH");
 
             GitRemoteFunction remoteFunction;
             if (isFetch && isPush)