Adding txtpb extension to Protocol Buffer Text Format

[milesflo]

Description

The Text Format specification has consolidated its canonical file extension to txtpb, with textproto still supported in some legacy tooling...

From the Docs:

.txtpb is the canonical text format file extension and should be preferred to the alternatives. This suffix is preferred for its brevity and consistency with the official wire-format file extension .binpb. The legacy canonical extension .textproto still has widespread usage and tooling support. Some tooling also supports the legacy extensions .textpb and .pbtxt. All other extensions besides the above are strongly discouraged; in particular, extensions such as .protoascii wrongly imply that text format is ascii-only, and others like .pb.txt are not recognized by common tooling. METADATA files are special text format proto files that lack any extension.

To Protocol Buffer Text Format:

Add Extensions

• txtpb canonical extension by the standard

Checklist:

• I am adding a new extension to a language.
  • The new extension is used in hundreds of repositories on GitHub.com
    • Search results for each extension:
      • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.txtpb
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • Waymo submission.txtpb
    • Sample license(s):
      • Apache 2.0
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

[lildude]

Along with the inline comment, we will also require samples of the new extensions files, and for the popularity requirements to be met.

[milesflo]

@lildude Squashed change & comment updated 👍

[lildude]

We still need a sample for the new extension.

[milesflo]

We still need a sample for the new extension.

Ahh I see. Done: 0fc3707

[lildude]

Thanks but as stated in the CONTRIBUTING.md file, the sample should be a real world sample. This appears to be a contrived "hello world" like sample. We also need to know the source of the sample and the license of the file. This was a point in the template you removed when opening this PR, which brings me to that port, please put back the template and fill it in… it's there for a reason 😉

[milesflo]

@lildude Updated the sample, readded the template, and added links to everything

[dougthor42]

Would it be possible to have an exception for the "pending popularity" requirement?

At least within our org (https://github.com/qh-lab), the only reason we didn't use .txtpb is because linguist doesn't highlight it. I'm sure other orgs/repos had the same thought.

[lildude]

Would it be possible to have an exception for the "pending popularity" requirement?

Unfortunately we can't as it sets a precedent we don't want to fight each and every time someone develops "the next greatest thing, promise on my hamster's life".

As Linguist already knows about the language, you can use an override to set the language until this PR is merged and deployed.

[dougthor42]

I am disappointed, but completely understand and agree. But I had to try 😉.

Also, good to know about overrides! I'll let our team know. Thanks!

Changes applied

[lildude]

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.