Add .h.in to C#7227
Merged
lildude merged 3 commits intogithub-linguist:mainfrom Feb 2, 2025
donno2048:patch-1
Merged
Conversation
from line 4256 (iirc) we know linguist does recognize dynamically created files
lildude
requested changes
Jan 31, 2025
Member
lildude
left a comment
There was a problem hiding this comment.
Please follow the directions for adding a new extension as detailed in the CONTRIBUTING.md file and please put back and complete the "I am adding a new extension to a language." section of the PR template you have removed - it's there for a reason.
Contributor
Author
|
@lildude did you mean adding a sample? If so, I added one and updated the PR comment |
add CEN64's common.h.in
Member
|
If these files are dynamically created, would it make sense to mark them as generated as part of this PR? This means they will be suppressed in PR diffs and excluded from the stats by default. |
Contributor
Author
|
@lildude they're used to generate |
lildude
approved these changes
Feb 2, 2025
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From line 4256 (iirc) we know linguist does recognize dynamically created files
Checklist: