Support JetBrains colour scheme (.icls) files#7851
Merged
lildude merged 3 commits intogithub-linguist:mainfrom Mar 16, 2026
Merged
Support JetBrains colour scheme (.icls) files#7851lildude merged 3 commits intogithub-linguist:mainfrom
.icls) files#7851lildude merged 3 commits intogithub-linguist:mainfrom
Conversation
Alhadis
changed the title
.icls) files
Alhadis
previously approved these changes
Mar 15, 2026
Collaborator
There was a problem hiding this comment.
Usage checks out; at least ~11.1k .icls files lack an XML declaration, meaning that Linguist's XML strategy isn't catching these files. Hence, adding this to XML's file-extensions list is warranted.
Not sure why the tests are failing, though. 🤔 EDIT: Never mind, I figured it out. I've pushed a fix to the PR.
lildude
approved these changes
Mar 16, 2026
Member
|
LGTM. Thanks. Important The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds JetBrains colour scheme (
.icls) files to the list of supported XML extensions.Checklist
~11.1k search results
Deep_Ocean.icls: Source | MIT-licensed