-
Notifications
You must be signed in to change notification settings - Fork 43
Resolve editing mistake and update some backend code #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
50cfe71
Fixed error in exercise 3
GeekTrainer 2b10378
Added note
GeekTrainer 45466bb
Added note about scripts
GeekTrainer 92d3ae9
Updated max requests
GeekTrainer b372a05
Add Playwright installation to environment setup script
GeekTrainer 2633c37
Updated instructions
GeekTrainer 581cfb1
Added agent notes
GeekTrainer 74d4af3
Updated versions
GeekTrainer 3599ed7
Updated tests and configuration
GeekTrainer a099237
Removed unused variable
GeekTrainer 6adc437
Updated astro version
GeekTrainer cab352f
Updated config file
GeekTrainer 52fb32c
Updated line number
GeekTrainer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,27 @@ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.describe('Home Page', () => { | ||
| test('should display the correct title', async ({ page }) => { | ||
| test.beforeEach(async ({ page }) => { | ||
| await page.goto('/'); | ||
|
|
||
| }); | ||
|
|
||
| test('should display the correct title', async ({ page }) => { | ||
| // Check that the page title is correct | ||
| await expect(page).toHaveTitle('Tailspin Toys - Crowdfunding your new favorite game!'); | ||
| }); | ||
|
|
||
| test('should display the main heading', async ({ page }) => { | ||
| await page.goto('/'); | ||
|
|
||
| // Check that the main heading is present | ||
| const mainHeading = page.locator('h1').first(); | ||
| await expect(mainHeading).toHaveText('Tailspin Toys'); | ||
| // Check that the main page heading is present | ||
| await expect(page.getByRole('heading', { name: 'Welcome to Tailspin Toys', exact: true })).toBeVisible(); | ||
| }); | ||
|
|
||
| test('should display the site branding in header', async ({ page }) => { | ||
| // Check that the site branding is present in the header (no longer an h1) | ||
| await expect(page.getByText('Tailspin Toys').first()).toBeVisible(); | ||
| }); | ||
|
|
||
| test('should display the welcome message', async ({ page }) => { | ||
| await page.goto('/'); | ||
|
|
||
| // Check that the welcome message is present | ||
| const welcomeMessage = page.locator('p').first(); | ||
| await expect(welcomeMessage).toHaveText('Find your next game! And maybe even back one! Explore our collection!'); | ||
| // Check that the welcome message is present using more specific locator | ||
| await expect(page.getByText('Find your next game! And maybe even back one! Explore our collection!')).toBeVisible(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic should check that both publisher AND category exist, not OR. The comment above states 'Check that either publisher or category (or both) are present' but the test expects both to be present based on the original logic.
See below for a potential fix: