Merge pull request #8 from chrisreddington/copilot/fix-7

Fix ESLint Errors in Shared Library Workspace

Author: chrisreddington

shared/src/constants/game-constants.ts

@@ -81,6 +81,6 @@ export function isValidGameStatus(status: string): status is GameStatus {
 /**
  * Get difficulty display configuration
  */
-export function getDifficultyDisplay(difficulty: Difficulty) {
+export function getDifficultyDisplay(difficulty: Difficulty): { emoji: string; label: string } {
   return DIFFICULTY_DISPLAY[difficulty]
 }

shared/src/games/rock-paper-scissors.ts

@@ -95,7 +95,7 @@ export class RockPaperScissorsGame implements Game<RPSGameState, RPSMove> {
     newRounds[gameState.currentRound] = currentRound;
 
     let newCurrentRound = gameState.currentRound;
-    let newScores = { ...gameState.scores };
+    const newScores = { ...gameState.scores };
     let newCurrentPlayerId = gameState.currentPlayerId;
 
     // If both players have made their choices, resolve the round

shared/src/storage/game-storage.test.ts

@@ -1,7 +1,7 @@
 import { vi } from 'vitest'
 import * as gameStorage from './game-storage';
 import * as sqliteStorage from './sqlite-storage';
-import type { GameSession, Player } from '../types/game';
+import type { GameSession } from '../types/game';
 import type { TicTacToeGameState, RPSGameState } from '../types/games';
 
 // Mock sqlite-storage module

shared/src/storage/mcp-api-client.ts

@@ -1,20 +1,20 @@
-import type { GameSession } from '../types/game'
-import type { TicTacToeGameState, RPSGameState } from '../types/games'
+import type { GameSession, Player } from '../types/game'
+import type { TicTacToeGameState, RPSGameState, TicTacToeMove, RPSMove } from '../types/games'
 import { httpGet, httpPost, WEB_API_BASE } from '../utils/http-client'
 
 // MCP-specific API functions that make HTTP calls to web app
 export async function getTicTacToeGameForMCP(gameId: string): Promise<GameSession<TicTacToeGameState> | undefined> {
   try {
     // Get all games and find the one we want
     const games = await httpGet(`${WEB_API_BASE}/api/games/tic-tac-toe`)
-    return games.find((game: any) => game.gameState?.id === gameId)
+    return games.find((game: GameSession<TicTacToeGameState>) => game.gameState?.id === gameId)
   } catch (error) {
     console.error('Error fetching tic-tac-toe game via API:', error)
     return undefined
   }
 }
 
-export async function createTicTacToeGameForMCP(players: any[]): Promise<GameSession<TicTacToeGameState>> {
+export async function createTicTacToeGameForMCP(players: Player[]): Promise<GameSession<TicTacToeGameState>> {
   try {
     const playerName = players.find(p => !p.isAI)?.name || 'Player'
     return await httpPost(`${WEB_API_BASE}/api/games/tic-tac-toe`, { playerName })
@@ -24,7 +24,7 @@ export async function createTicTacToeGameForMCP(players: any[]): Promise<GameSes
   }
 }
 
-export async function makeTicTacToeMove(gameId: string, move: any, playerId: string): Promise<GameSession<TicTacToeGameState>> {
+export async function makeTicTacToeMove(gameId: string, move: TicTacToeMove, playerId: string): Promise<GameSession<TicTacToeGameState>> {
   try {
     return await httpPost(`${WEB_API_BASE}/api/games/tic-tac-toe/${gameId}/move`, { move, playerId })
   } catch (error) {
@@ -36,14 +36,14 @@ export async function makeTicTacToeMove(gameId: string, move: any, playerId: str
 export async function getRPSGameForMCP(gameId: string): Promise<GameSession<RPSGameState> | undefined> {
   try {
     const games = await httpGet(`${WEB_API_BASE}/api/games/rock-paper-scissors/mcp`)
-    return games.find((game: any) => game.gameState?.id === gameId)
+    return games.find((game: GameSession<RPSGameState>) => game.gameState?.id === gameId)
   } catch (error) {
     console.error('Error fetching RPS game via API:', error)
     return undefined
   }
 }
 
-export async function makeRPSMove(gameId: string, move: any, playerId: string): Promise<GameSession<RPSGameState>> {
+export async function makeRPSMove(gameId: string, move: RPSMove, playerId: string): Promise<GameSession<RPSGameState>> {
   try {
     return await httpPost(`${WEB_API_BASE}/api/games/rock-paper-scissors/${gameId}/move`, { move, playerId })
   } catch (error) {

shared/src/storage/sqlite-storage.ts

@@ -1,5 +1,4 @@
 import sqlite3 from 'sqlite3'
-import { promisify } from 'util'
 import path from 'path'
 import type { GameSession } from '../types/game'
 import type { TicTacToeGameState, RPSGameState } from '../types/games'

shared/src/testing/api-test-utils.ts

@@ -13,7 +13,13 @@ import type { TicTacToeGameState, RPSGameState, TicTacToeMove, RPSMove } from '.
  * Generic game mock factory
  * Creates a mock game instance with all required methods
  */
-export function createGameMock() {
+export function createGameMock(): {
+  getInitialState: ReturnType<typeof vi.fn>;
+  validateMove: ReturnType<typeof vi.fn>;
+  applyMove: ReturnType<typeof vi.fn>;
+  checkGameEnd: ReturnType<typeof vi.fn>;
+  getValidMoves: ReturnType<typeof vi.fn>;
+} {
   return {
     getInitialState: vi.fn(),
     validateMove: vi.fn(),
@@ -95,7 +101,10 @@ export function createMockGameSession<T extends BaseGameState>(gameState: T, gam
  * Vitest mock configuration for shared package games
  * Use this to create consistent mocks across API route tests
  */
-export function createSharedGameMocks(gameClass: string) {
+export function createSharedGameMocks(gameClass: string): {
+  mockImplementation: Record<string, unknown>;
+  mockGame: ReturnType<typeof createGameMock>;
+} {
   const mockGame = createGameMock()
 
   return {
@@ -110,7 +119,7 @@ export function createSharedGameMocks(gameClass: string) {
 /**
  * Create storage function mocks for a specific game type
  */
-export function createStorageMocks(gameType: GameType) {
+export function createStorageMocks(gameType: GameType): Record<string, ReturnType<typeof vi.fn>> {
   if (gameType === 'tic-tac-toe') {
     return {
       getTicTacToeGame: vi.fn(),

shared/src/testing/test-database.ts

@@ -51,7 +51,7 @@ export async function setupTestDatabase(
       }
 
       // Create tables synchronously to ensure they exist before tests run
-      const createTables = async () => {
+      const createTables = async (): Promise<void> => {
         try {
           await createTicTacToeTable()
           await createRPSTable()

shared/src/testing/vitest-setup.ts

@@ -12,7 +12,7 @@ import { setupTestDatabase, teardownTestDatabase } from './test-database'
  * Standard database setup for all packages
  * Call this in vitest.setup.ts files to ensure consistent database setup
  */
-export function setupStandardTestDatabase() {
+export function setupStandardTestDatabase(): void {
   // Setup test database before all tests
   beforeAll(async () => {
     try {

shared/src/types/game.ts

@@ -19,7 +19,7 @@ export interface BaseGameState {
   updatedAt: Date;
 }
 
-export interface GameMove<T = any> {
+export interface GameMove<T = unknown> {
   playerId: PlayerId;
   move: T;
   timestamp: Date;
@@ -36,7 +36,7 @@ export interface Game<TGameState extends BaseGameState, TMove> {
   applyMove(gameState: TGameState, move: TMove, playerId: PlayerId): TGameState;
   checkGameEnd(gameState: TGameState): GameResult | null;
   getValidMoves(gameState: TGameState, playerId: PlayerId): TMove[];
-  getInitialState(players: Player[], options?: any): TGameState;
+  getInitialState(players: Player[], options?: Record<string, unknown>): TGameState;
 }
 
 // Generic game session for API communication

shared/src/types/games.ts

@@ -1,4 +1,4 @@
-import { BaseGameState, GameMove } from './game';
+import { BaseGameState } from './game';
 
 // Tic-tac-toe specific types
 export type CellValue = 'X' | 'O' | null;