Add Elicitation, Linting, Convert test infrastructure, Other refinements

[chrisreddington]

This pull request makes significant improvements to type safety, code consistency, and developer tooling across the project, especially focusing on centralizing constants and types, removing duplication, and refactoring the testing and linting infrastructure. The most important changes are summarized below.

Type Safety and Constants Consolidation

• Centralizes key constants (DIFFICULTIES, GAME_TYPES, PLAYER_IDS, etc.) in the shared library, and enforces that all types like Difficulty, GameType, and PlayerId are derived from these constants using as const assertions. Updates copilot instructions to import these types instead of redefining union types.
• Updates function signatures and AI logic to use the shared Difficulty type, ensuring consistent difficulty handling across all games.

Testing Infrastructure Refactoring

• Migrates the MCP server package from Jest to Vitest for testing, removing all Jest-related configuration and setup files, and updating test scripts in package.json.
• Documents the use of shared testing utilities and mock data from the shared package, discouraging local duplication of test data.

Linting and Developer Tooling

• Adds an ESLint configuration at the root and in the MCP server package, using typescript-eslint for improved TypeScript linting and code quality enforcement. Customizes rules for the MCP server and adds ignore patterns.

Code Consistency and Minor Refactoring

• Cleans up test files to use imported types and constants, removes unnecessary type imports, and clarifies variable usage for better readability and maintainability.

Build and Runtime Adjustments

• Updates server entry points and script references in both the VSCode workspace and package.json to use server.js instead of index.js, aligning with the new build output.

These changes collectively improve maintainability and type safety across the codebase.

[Copilot]

Pull Request Overview

This PR significantly modernizes the codebase by migrating from Jest to Vitest, improving type safety through centralized constants, and refactoring testing infrastructure across all packages. The main focus is on eliminating duplication and establishing consistent patterns.

Key changes include:

• Migration from Jest to Vitest testing framework with shared test utilities
• Centralization of game constants and types in the shared package
• Addition of ESLint configuration and interactive elicitation features

Reviewed Changes

Copilot reviewed 93 out of 96 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web/vitest.setup.ts	New Vitest setup replacing Jest configuration
web/vitest.config.ts	Vitest configuration with coverage thresholds
web/package.json	Updated dependencies from Jest to Vitest
shared/src/constants/game-constants.ts	New centralized constants module
shared/src/testing/vitest-setup.ts	Shared test setup utilities
mcp-server/src/handlers/elicitation-handlers.ts	New interactive user preference collection
mcp-server/src/handlers/tool-handlers.ts	Refactored to use centralized constants

Comments suppressed due to low confidence (1)

mcp-server/src/utils/http-client.ts:48

• The type casting '(games as GenericGameStateWrapper[])' assumes the API response structure without validation. Consider adding runtime type checking or using a type guard to ensure the response matches the expected structure before casting.

export async function getGameViaAPI(gameType: string, gameId: string): Promise<GenericGameStateWrapper | undefined> {
  try {
    const games = await httpGet(`${WEB_API_BASE}/api/games/${gameType}/mcp`)
  return (games as GenericGameStateWrapper[]).find((game) => game.gameState?.id === gameId)
  } catch (error) {
    console.error(`Error fetching ${gameType} game via API:`, error)
    return undefined
  }
}