Don't throw if VsTippingService API has changed

Author: jcansdale

src/GitHub.Services.Vssdk/Services/TippingService.cs

@@ -64,7 +64,14 @@ void RequestCalloutDisplay(Guid clientId, Guid calloutId, string title, string m
             Assumes.Present(tippingService);
             var currentMethod = MethodBase.GetCurrentMethod();
             var parameterTypes = currentMethod.GetParameters().Select(p => p.ParameterType).ToArray();
-            var method = tippingService.GetType().GetMethod(currentMethod.Name, parameterTypes);
+            var tippingServiceType = tippingService.GetType();
+            var method = tippingServiceType.GetMethod(currentMethod.Name, parameterTypes);
+            if (method == null)
+            {
+                log.Error("Couldn't find method on {Type} with parameters like {Method}", tippingServiceType, currentMethod);
+                return;
+            }
+
             var arguments = new object[] { clientId, calloutId, title, message, isPermanentlyDismissible, anchor,
                     vsCommandGroupId, vsCommandId };
             method.Invoke(tippingService, arguments);

test/GitHub.Services.Vssdk.UnitTests/TippingServiceTests.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Runtime.InteropServices;
 using NUnit.Framework;
 using GitHub.Services.Vssdk.Services;
 using NSubstitute;
@@ -16,5 +17,16 @@ public void No_Exception_When_Cant_Find_SVsTippingService()
             Assert.DoesNotThrow(() =>
                 target.RequestCalloutDisplay(Guid.Empty, "title", "message", true, null, Guid.Empty, 0));
         }
+
+        [Test]
+        public void No_Exception_When_Api_Has_Changed()
+        {
+            var serviceProvider = Substitute.For<IServiceProvider>();
+            serviceProvider.GetService(null).ReturnsForAnyArgs(new object());
+            var target = new TippingService(serviceProvider);
+
+            Assert.DoesNotThrow(() =>
+                target.RequestCalloutDisplay(Guid.Empty, "title", "message", true, null, Guid.Empty, 0));
+        }
     }
 }