Merge branch 'master' into donokuda/tall-orgs

Author: Meaghan Lewis

Directory.Build.Props

@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <Product>GitHub Extension for Visual Studio</Product>
-    <Version>2.6.1.0</Version>
+    <Version>2.7.0.0</Version>
     <Copyright>Copyright © GitHub, Inc. 2014-2018</Copyright>
     <LangVersion>7.3</LangVersion>
   </PropertyGroup>

README.md

@@ -92,6 +92,22 @@ Logs can be viewed at the following location:
 
 `%LOCALAPPDATA%\GitHubVisualStudio\extension.log`
 
+## Troubleshooting
+
+If you have issues building with failures similar to:
+
+> "The type or namespace name does not exist..."
+
+or
+
+> "Unable to find project... Check that the project reference is valid and that the project file exists."*
+
+Close Visual Studio and run the following command to update submodules and clean your environment.
+
+```txt
+clean.cmd
+```
+
 ## More information
 - Andreia Gaita's [presentation](https://www.youtube.com/watch?v=hz2hCO8e_8w) at Codemania 2016 about this extension.
 
@@ -104,4 +120,3 @@ Visit the [Contributor Guidelines](CONTRIBUTING.md) for details on how to contri
 Copyright 2015 - 2018 GitHub, Inc.
 
 Licensed under the [MIT License](LICENSE.md)
-

appveyor.yml

@@ -1,5 +1,5 @@
 os: Visual Studio 2017
-version: '2.6.1.{build}'
+version: '2.7.0.{build}'
 skip_tags: true
 install:
 - ps: |

clean.cmd

@@ -0,0 +1,3 @@
+git submodule update --init
+git clean -xdff
+git submodule foreach git clean -xdff

src/CredentialManagement/NativeMethods.cs

@@ -4,6 +4,10 @@
 using System.Text;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1034 // Nested types should not be visible
+#pragma warning disable CA1051 // Do not declare visible instance fields
+#pragma warning disable CA1707 // Identifiers should not contain underscores
+
 namespace GitHub.Authentication.CredentialManagement
 {
     public static class NativeMethods

src/GitHub.Api/GlobalSuppressions.cs

@@ -0,0 +1,9 @@
+// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Reliability", "CA2007:Do not directly await a Task", Justification = "Discouraged for VSSDK projects.")]
+

src/GitHub.Api/LoginManager.cs

@@ -289,7 +289,7 @@ async Task<ApplicationAuthorization> HandleTwoFactorAuthorization(
             }
         }
 
-        ApplicationAuthorization EnsureNonNullAuthorization(ApplicationAuthorization auth)
+        static ApplicationAuthorization EnsureNonNullAuthorization(ApplicationAuthorization auth)
         {
             // If a mock IGitHubClient is not set up correctly, it can return null from
             // IGutHubClient.Authorization.Create - this will cause an infinite loop in Login()

src/GitHub.App/Api/ApiClient.cs

@@ -18,7 +18,6 @@ namespace GitHub.Api
 {
     public partial class ApiClient : IApiClient
     {
-        const string ScopesHeader = "X-OAuth-Scopes";
         const string ProductName = Info.ApplicationInfo.ApplicationDescription;
         static readonly ILogger log = LogManager.ForContext<ApiClient>();
 

src/GitHub.App/Collections/VirtualizingList.cs

@@ -12,6 +12,10 @@
 using GitHub.Logging;
 using Serilog;
 
+#pragma warning disable CA1010 // Collections should implement generic interface
+#pragma warning disable CA1033 // Interface methods should be callable by child types
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+
 namespace GitHub.Collections
 {
     /// <summary>

src/GitHub.App/Collections/VirtualizingListCollectionView.cs

@@ -4,6 +4,10 @@
 using System.Collections.Specialized;
 using System.Windows.Data;
 
+#pragma warning disable CA1010 // Collections should implement generic interface
+#pragma warning disable CA1033 // Interface methods should be callable by child types
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+
 namespace GitHub.Collections
 {
     /// <summary>