Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 172aba3

Browse files
committed
Attempt at fixing tests
Tests are failing on the buildbot and it looks like it's because one test is clobbering data for another test. The only thing these tests share is the global ServiceProvider set, so put these test classes in the same collection so xunit doesn't parallelize them.
1 parent d8b2d16 commit 172aba3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/UnitTests/GitHub.App/Models/RepositoryModelTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public void DifferentContentEqualsFalse(string name1, string url1, string name2,
5353
}
5454
}
5555

56+
[Collection("PackageServiceProvider global data tests")]
5657
public class PathConstructorTests : TempFileBaseClass
5758
{
5859
[Fact]

src/UnitTests/GitHub.Extensions/SimpleRepositoryModelExtensionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
using UnitTests;
88
using Xunit;
99
using GitHub.Primitives;
10-
using System.Linq;
1110

11+
[Collection("PackageServiceProvider global data tests")]
1212
public class SimpleRepositoryModelExtensionTests : TempFileBaseClass
1313
{
1414
void SetupRepository(string sha)

0 commit comments

Comments
 (0)