Remove async from tests with no await

Author: jcansdale

test/UnitTests/GitHub.Api/LoginManagerTests.cs

@@ -250,7 +250,7 @@ public async Task ErasesLoginWhenNonOctokitExceptionThrown()
             var keychain = Substitute.For<IKeychain>();
             var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
             var oauthListener = Substitute.For<IOAuthCallbackListener>();
-          
+
             var target = new LoginManager(keychain, tfa, oauthListener, "id", "secret", scopes);
             Assert.ThrowsAsync<InvalidOperationException>(async () => await target.Login(host, client, "foo", "bar"));
 
@@ -283,7 +283,7 @@ public async Task ErasesLoginWhenNonOctokitExceptionThrownIn2FA()
         }
 
         [Test]
-        public async Task InvalidResponseScopesCauseException()
+        public void InvalidResponseScopesCauseException()
         {
             var client = CreateClient(responseScopes: new[] { "user", "repo" });
             client.Authorization.GetOrCreateApplicationAuthentication("id", "secret", Arg.Any<NewAuthorization>())

test/UnitTests/GitHub.App/Caches/ImageCacheTests.cs

@@ -55,7 +55,7 @@ public async Task WhenLoadingFromCacheFailsInvalidatesCacheEntry()
             Assert.That(retrieved, Is.Null);
             Assert.ThrowsAsync<KeyNotFoundException>(async () => await cache.Get("https://fake/"));
         }
-        
+
         [Test]
         public async Task DownloadsImageWhenMissingAndCachesIt()
         {
@@ -76,7 +76,7 @@ public async Task DownloadsImageWhenMissingAndCachesIt()
         }
 
         [Test]
-        public async Task ThrowsKeyNotFoundExceptionWhenItemNotInCacheAndImageFetchThrowsException()
+        public void ThrowsKeyNotFoundExceptionWhenItemNotInCacheAndImageFetchThrowsException()
         {
             var imageUri = new Uri("https://example.com/poop.gif");
             var cacheFactory = Substitute.For<IBlobCacheFactory>();
@@ -91,7 +91,7 @@ public async Task ThrowsKeyNotFoundExceptionWhenItemNotInCacheAndImageFetchThrow
         }
 
         [Test]
-        public async Task ThrowsKeyNotFoundExceptionWhenItemNotInCacheAndImageFetchReturnsEmpty()
+        public void ThrowsKeyNotFoundExceptionWhenItemNotInCacheAndImageFetchReturnsEmpty()
         {
             var imageUri = new Uri("https://example.com/poop.gif");
             var cache = new InMemoryBlobCache();

test/UnitTests/GitHub.App/Services/PullRequestServiceTests.cs

@@ -291,7 +291,7 @@ public async Task ExtractBase_MergeBaseAvailable_UseMergeBaseSha()
         }
 
         [Test]
-        public async Task MergeBaseNotAvailable_ThrowsNotFoundException()
+        public void MergeBaseNotAvailable_ThrowsNotFoundException()
         {
             var baseFileContent = "baseFileContent";
             var headFileContent = "headFileContent";

test/UnitTests/GitHub.VisualStudio/Services/ConnectionManagerTests.cs

@@ -47,7 +47,7 @@ public async Task ReturnsInvalidConnections()
             var result = await target.GetLoadedConnections();
 
             Assert.That(2, Is.EqualTo(result.Count));
-            Assert.That("https://github.com/",Is.EqualTo(result[0].HostAddress.WebUri.ToString()));
+            Assert.That("https://github.com/", Is.EqualTo(result[0].HostAddress.WebUri.ToString()));
             Assert.That("https://invalid.com/", Is.EqualTo(result[1].HostAddress.WebUri.ToString()));
             Assert.That(result[0].ConnectionError, Is.Null);
             Assert.That(result[1].ConnectionError, Is.Not.Null);
@@ -121,7 +121,7 @@ public async Task AddsLoggedInConnectionToConnections()
         }
 
         [Test]
-        public async Task ThrowsWhenLoginFails()
+        public void ThrowsWhenLoginFails()
         {
             var target = new ConnectionManager(
                 CreateProgram(),
@@ -136,7 +136,7 @@ public async Task ThrowsWhenLoginFails()
         }
 
         [Test]
-        public async Task ThrowsWhenExistingConnectionExists()
+        public void ThrowsWhenExistingConnectionExists()
         {
             var target = new ConnectionManager(
                 CreateProgram(),
@@ -208,7 +208,7 @@ public async Task RemovesConnectionFromConnections()
         }
 
         [Test]
-        public async Task ThrowsIfConnectionDoesntExist()
+        public void ThrowsIfConnectionDoesntExist()
         {
             var loginManager = CreateLoginManager();
             var target = new ConnectionManager(