Remove Octokit dependency from BranchModel

BranchModel is now a pure model. 🎉

Author: jcansdale

src/GitHub.App/Services/ModelService.cs

@@ -270,7 +270,7 @@ public IObservable<IPullRequestModel> CreatePullRequest(ILocalRepositoryModel so
                                 new NewPullRequest(title,
                                                    string.Format(CultureInfo.InvariantCulture, "{0}:{1}", sourceRepository.Owner, sourceBranch.Name),
                                                    targetBranch.Name)
-                                                   { Body = body },
+                                { Body = body },
                                 targetRepository.Owner,
                                 targetRepository.Name)
                             .Select(PullRequestCacheItem.Create)
@@ -366,7 +366,7 @@ public IObservable<IBranch> GetBranches(IRepositoryModel repo)
 
             return Observable.Defer(() => keyobs
                     .SelectMany(key => ApiClient.GetBranches(repo.CloneUrl.Owner, repo.CloneUrl.RepositoryName)))
-                .Select(x => new BranchModel(x, repo));
+                .Select(x => new BranchModel(x.Name, repo));
         }
 
         static GitIgnoreItem Create(GitIgnoreCacheItem item)
@@ -452,7 +452,7 @@ public IObservable<Unit> InsertUser(AccountCacheItem user)
         }
 
         protected virtual void Dispose(bool disposing)
-        {}
+        { }
 
         public void Dispose()
         {
@@ -493,7 +493,7 @@ public static RepositoryCacheItem Create(Repository apiRepository)
                 return new RepositoryCacheItem(apiRepository);
             }
 
-            public RepositoryCacheItem() {}
+            public RepositoryCacheItem() { }
 
             public RepositoryCacheItem(Repository apiRepository)
             {
@@ -529,7 +529,7 @@ public static PullRequestCacheItem Create(PullRequest pr)
                 return new PullRequestCacheItem(pr);
             }
 
-            public PullRequestCacheItem() {}
+            public PullRequestCacheItem() { }
 
             public PullRequestCacheItem(PullRequest pr)
             {
@@ -563,7 +563,7 @@ public PullRequestCacheItem(PullRequest pr)
                 Timestamp = UpdatedAt;
             }
 
-            public string Title {get; set; }
+            public string Title { get; set; }
             public int Number { get; set; }
             public GitReferenceCacheItem Base { get; set; }
             public GitReferenceCacheItem Head { get; set; }
@@ -574,7 +574,7 @@ public PullRequestCacheItem(PullRequest pr)
             public DateTimeOffset CreatedAt { get; set; }
             public DateTimeOffset UpdatedAt { get; set; }
             public string Body { get; set; }
-            
+
             // Nullable for compatibility with old caches.
             public PullRequestStateEnum? State { get; set; }
 

src/GitHub.Exports/Models/BranchModel.cs

@@ -20,17 +20,7 @@ public BranchModel(string name, IRepositoryModel repo)
 
             Name = DisplayName = name;
             Repository = repo;
-            Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
-        }
-
-        public BranchModel(Octokit.Branch branch, IRepositoryModel repo)
-        {
-            Extensions.Guard.ArgumentNotNull(branch, nameof(branch));
-            Extensions.Guard.ArgumentNotNull(repo, nameof(repo));
-
-            Name = DisplayName = branch.Name;
-            Repository = repo;
-            Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
+            Id = string.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
         }
 
         public string Id { get; private set; }