Remove IGitService dependency from BranchModel

Removed dead and buggy code from BranchModel constructorer. We
construct BranchModel from the HEAD branch, which isn't a remote
branch. No need to construct a RepositoryModel from a URL.

Author: jcansdale

src/GitHub.Exports/Models/BranchModel.cs

@@ -1,11 +1,18 @@
 using System;
 using System.Globalization;
-using GitHub.Services;
 
 namespace GitHub.Models
 {
     public class BranchModel : IBranch
     {
+        public BranchModel(string name, IRepositoryModel repo, string sha, bool isTracking, string trackedSha) :
+            this(name, repo)
+        {
+            IsTracking = isTracking;
+            Sha = sha;
+            TrackedSha = trackedSha;
+        }
+
         public BranchModel(string name, IRepositoryModel repo)
         {
             Extensions.Guard.ArgumentNotEmptyString(name, nameof(name));
@@ -26,21 +33,6 @@ public BranchModel(Octokit.Branch branch, IRepositoryModel repo)
             Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
         }
 
-        public BranchModel(LibGit2Sharp.Branch branch, IRepositoryModel repo, IGitService gitService)
-        {
-            Extensions.Guard.ArgumentNotNull(branch, nameof(branch));
-            Extensions.Guard.ArgumentNotNull(repo, nameof(repo));
-            Name = DisplayName = branch.FriendlyName;
-#pragma warning disable 0618 // TODO: Replace `Branch.Remote` with `Repository.Network.Remotes[branch.RemoteName]`.
-            // NOTE: This method expects a localPath not a URL!
-            Repository = branch.IsRemote ? gitService.CreateLocalRepositoryModel(branch.Remote.Url) : repo;
-#pragma warning restore 0618
-            IsTracking = branch.IsTracking;
-            Sha = branch.Tip?.Sha;
-            TrackedSha = branch.TrackedBranch?.Tip?.Sha;
-            Id = String.Format(CultureInfo.InvariantCulture, "{0}/{1}", Repository.Owner, Name);
-        }
-
         public string Id { get; private set; }
         public string Name { get; private set; }
         public IRepositoryModel Repository { get; private set; }

src/GitHub.Exports/Services/GitService.cs

@@ -57,14 +57,18 @@ public IBranch GetBranch(ILocalRepositoryModel model)
             var localPath = model.LocalPath;
             using (var repo = GetRepository(localPath))
             {
-                var headBranch = repo?.Head;
-                if (headBranch == null)
+                var branch = repo?.Head;
+                if (branch == null)
                 {
                     return null;
                 }
 
-                // BranchModel doesn't keep a reference to Repository
-                return new BranchModel(headBranch, model, this);
+                return new BranchModel(
+                    name: branch.FriendlyName,
+                    repo: model,
+                    sha: branch.Tip?.Sha,
+                    isTracking: branch.IsTracking,
+                    trackedSha: branch.TrackedBranch?.Tip?.Sha);
             }
         }