Correcting the remaining usages of node ids

Author: StanleyGoldman

src/GitHub.Exports.Reactive/Services/IPullRequestSession.cs

@@ -109,12 +109,10 @@ Task<IPullRequestReviewCommentModel> PostReviewComment(
         /// Posts a PR review comment reply.
         /// </summary>
         /// <param name="body">The comment body.</param>
-        /// <param name="inReplyTo">The REST ID of the comment to reply to.</param>
         /// <param name="inReplyToNodeId">The GraphQL ID of the comment to reply to.</param>
         /// <returns>A comment model.</returns>
         Task<IPullRequestReviewCommentModel> PostReviewComment(
             string body,
-            int inReplyTo,
             string inReplyToNodeId);
 
         /// <summary>

src/GitHub.InlineReviews/Services/IPullRequestSessionService.cs

@@ -286,13 +286,13 @@ Task<IPullRequestReviewCommentModel> PostStandaloneReviewComment(ILocalRepositor
         /// <param name="user">The user posting the comment.</param>
         /// <param name="pullRequestNodeId">The pull request node id.</param>
         /// <param name="body">The comment body.</param>
-        /// <param name="inReplyTo">The comment ID to reply to.</param>
+        /// <param name="inReplyToNodeId">The comment node id to reply to.</param>
         /// <returns>A model representing the posted comment.</returns>
         Task<IPullRequestReviewCommentModel> PostStandaloneReviewCommentReply(ILocalRepositoryModel localRepository,
             IAccount user,
             string pullRequestNodeId,
             string body,
-            int inReplyTo);
+            string inReplyToNodeId);
 
         /// <summary>
         /// Delete a PR review comment.

src/GitHub.InlineReviews/Services/PullRequestSession.cs

@@ -194,20 +194,18 @@ public async Task<IPullRequestReviewCommentModel> EditComment(string commentNode
         /// <inheritdoc/>
         public async Task<IPullRequestReviewCommentModel> PostReviewComment(
             string body,
-            int inReplyTo,
             string inReplyToNodeId)
         {
             IPullRequestReviewCommentModel model;
 
             if (!HasPendingReview)
             {
-                var pullRequestNodeId = await GetPullRequestNodeId();
                 model = await service.PostStandaloneReviewCommentReply(
                     LocalRepository,
                     User,
                     pullRequestNodeId,
                     body,
-                    inReplyTo);
+                    inReplyToNodeId);
             }
             else
             {

src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

@@ -574,7 +574,7 @@ public async Task<IPullRequestReviewCommentModel> PostStandaloneReviewComment(
                             OriginalCommitId = x.OriginalCommit.Oid,
                             PullRequestReviewId = x.PullRequestReview.DatabaseId.Value,
                             User = user,
-                            IsPending = true,
+                            IsPending = false
                         }));
 
             var result = (await graphql.Run(mutation)).First();
@@ -588,10 +588,11 @@ public async Task<IPullRequestReviewCommentModel> PostStandaloneReviewCommentRep
             IAccount user,
             string pullRequestNodeId,
             string body,
-            int inReplyTo)
+            string inReplyToNodeId)
         {
             var review = await CreatePendingReview(localRepository, user, pullRequestNodeId);
-            var comment = await PostPendingReviewCommentReply(localRepository, user, review.Id.ToString(), body, inReplyTo.ToString());
+            var comment = await PostPendingReviewCommentReply(localRepository, user, review.NodeId, body, inReplyToNodeId);
+            await SubmitPendingReview(localRepository, user, review.NodeId, null, PullRequestReviewEvent.Comment);
             return comment;
         }
 

src/GitHub.InlineReviews/ViewModels/InlineCommentThreadViewModel.cs

@@ -72,9 +72,8 @@ async Task<ICommentModel> DoPostComment(object parameter)
             Guard.ArgumentNotNull(parameter, nameof(parameter));
 
             var body = (string)parameter;
-            var replyId = Comments[0].Id;
             var nodeId = Comments[0].NodeId;
-            return await Session.PostReviewComment(body, replyId, nodeId);
+            return await Session.PostReviewComment(body, nodeId);
         }
 
         async Task<ICommentModel> DoEditComment(object parameter)

test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionTests.cs

@@ -536,14 +536,14 @@ public async Task PostsReplyToCorrectForkWithNoPendingReview()
                 var service = CreateService();
                 var target = CreateTarget(service, "fork", "owner", false);
 
-                await target.PostReviewComment("New Comment", 1, "node1");
+                await target.PostReviewComment("New Comment", "node1");
 
                 await service.Received(1).PostStandaloneReviewCommentReply(
                     target.LocalRepository,
                     target.User,
                     PullRequestNodeId,
                     "New Comment",
-                    1);
+                    "node1");
             }
 
             [Test]
@@ -570,7 +570,7 @@ public async Task PostsReplyToCorrectForkWithPendingReview()
                 var service = CreateService();
                 var target = CreateTarget(service, "fork", "owner", true);
 
-                await target.PostReviewComment("New Comment", 1, "node1");
+                await target.PostReviewComment("New Comment", "node1");
 
                 await service.Received(1).PostPendingReviewCommentReply(
                     target.LocalRepository,

test/GitHub.InlineReviews.UnitTests/ViewModels/InlineCommentPeekViewModelTests.cs

@@ -210,7 +210,7 @@ public async Task CommittingEditDoesntRetainSubmittedCommentInPlaceholderAfterPo
 
             Assert.That(2, Is.EqualTo(target.Thread.Comments.Count));
 
-            sessionManager.CurrentSession.PostReviewComment(null, 0, null)
+            sessionManager.CurrentSession.PostReviewComment(null, null)
                 .ReturnsForAnyArgs(async x =>
                 {
                     var file = await sessionManager.GetLiveFile(

test/GitHub.InlineReviews.UnitTests/ViewModels/InlineCommentThreadViewModelTests.cs

@@ -65,7 +65,7 @@ public void PostsCommentInReplyToCorrectComment()
             target.Comments[2].Body = "New Comment";
             target.Comments[2].CommitEdit.Execute(null);
 
-            session.Received(1).PostReviewComment("New Comment", 1, "node1");
+            session.Received(1).PostReviewComment("New Comment", "node1");
         }
 
         IApiClient CreateApiClient()