Merge branch 'master' into feature/save-drafts

Author: grokys

.ncrunch/GitHub.App.UnitTests.v3.ncrunchproject

@@ -0,0 +1,5 @@
+<ProjectConfiguration>
+  <Settings>
+    <CopyReferencedAssembliesToWorkspace>True</CopyReferencedAssembliesToWorkspace>
+  </Settings>
+</ProjectConfiguration>

.ncrunch/GitHub.Exports.UnitTests.v3.ncrunchproject

@@ -0,0 +1,5 @@
+<ProjectConfiguration>
+  <Settings>
+    <CopyReferencedAssembliesToWorkspace>True</CopyReferencedAssembliesToWorkspace>
+  </Settings>
+</ProjectConfiguration>

GitHubVS.sln

@@ -131,6 +131,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ReactiveUI.Testing", "submo
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ReactiveUI.Wpf", "submodules\reactiveui\src\ReactiveUI.Wpf\ReactiveUI.Wpf.csproj", "{E899B03C-6E8E-4375-AB65-FC925D721D8B}"
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "InstallAndStart", "test\Launcher\InstallAndStart.csproj", "{79F32BE1-2764-4DBA-97F6-21053DE44270}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -530,6 +532,16 @@ Global
 		{E899B03C-6E8E-4375-AB65-FC925D721D8B}.Release|Any CPU.Build.0 = Release|Any CPU
 		{E899B03C-6E8E-4375-AB65-FC925D721D8B}.ReleaseWithoutVsix|Any CPU.ActiveCfg = Release|Any CPU
 		{E899B03C-6E8E-4375-AB65-FC925D721D8B}.ReleaseWithoutVsix|Any CPU.Build.0 = Release|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.DebugCodeAnalysis|Any CPU.ActiveCfg = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.DebugCodeAnalysis|Any CPU.Build.0 = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.DebugWithoutVsix|Any CPU.ActiveCfg = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.DebugWithoutVsix|Any CPU.Build.0 = Debug|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.Release|Any CPU.Build.0 = Release|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.ReleaseWithoutVsix|Any CPU.ActiveCfg = Release|Any CPU
+		{79F32BE1-2764-4DBA-97F6-21053DE44270}.ReleaseWithoutVsix|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

GitHubVS.v3.ncrunchsolution

@@ -7,7 +7,7 @@
     <AdditionalFilesToIncludeForSolution>
       <Value>lib\**.*</Value>
     </AdditionalFilesToIncludeForSolution>
-    <AllowParallelTestExecution>False</AllowParallelTestExecution>
+    <AllowParallelTestExecution>True</AllowParallelTestExecution>
     <ProjectConfigStoragePathRelativeToSolutionDir>.ncrunch</ProjectConfigStoragePathRelativeToSolutionDir>
     <SolutionConfigured>True</SolutionConfigured>
   </Settings>

nuget.config

@@ -2,7 +2,8 @@
 <configuration>
   <packageSources>
     <add key="nuget.org" value="https://www.nuget.org/api/v2/" />
-	<add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />
+    <add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />
+    <add key="vsixtesting" value="https://www.myget.org/F/vsixtesting/api/v3/index.json" />
     <add key="Custom Packages for GHfVS" value="lib" />
   </packageSources>
   <activePackageSource>

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

@@ -96,7 +96,7 @@ public PullRequestDetailViewModelDesigner()
 
             Files = new PullRequestFilesViewModelDesigner();
 
-            Checks = new PullRequestCheckViewModelDesigner[0];
+            Checks = Array.Empty<PullRequestCheckViewModelDesigner>();
         }
 
         public PullRequestDetailModel Model { get; }

src/GitHub.App/SampleData/PullRequestUserReviewsViewModelDesigner.cs

@@ -27,7 +27,7 @@ public PullRequestUserReviewsViewModelDesigner()
                 {
                     IsExpanded = true,
                     HasDetails = true,
-                    FileComments = new IPullRequestReviewFileCommentViewModel[0],
+                    FileComments = Array.Empty<IPullRequestReviewFileCommentViewModel>(),
                     StateDisplay = "approved",
                     Model = new PullRequestReviewModel
                     {

src/GitHub.App/Services/ModelService.cs

@@ -320,7 +320,7 @@ IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetUserRepositories(Repositor
                         log.Error(e,
                             "Retrieving {RepositoryType} user repositories failed because user is not stored in the cache",
                             repositoryType);
-                        return Observable.Return(new IRemoteRepositoryModel[] {});
+                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
                     });
         }
 
@@ -355,7 +355,7 @@ IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetOrganizationRepositories(s
                     {
                         log.Error(e, "Retrieveing {Organization} org repositories failed because user is not stored in the cache",
                             organization);
-                        return Observable.Return(new IRemoteRepositoryModel[] {});
+                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
                     });
         }
 

src/GitHub.App/Services/StandardUserErrors.cs

@@ -189,7 +189,7 @@ public static IObservable<RecoveryOptionResult> ShowUserErrorThatRequiresNavigat
 
             return exception.DisplayErrorMessage(
                 errorType,
-                new object[] { },
+                Array.Empty<object>(),
                 new[] { OpenBrowser("View Plans", account.Billing()), Cancel });
         }
 

src/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModel.cs

@@ -182,7 +182,7 @@ public async Task InitializeAsync(IConnection connection)
 
             accounts = modelService.GetAccounts()
                 .ObserveOn(RxApp.MainThreadScheduler)
-                .ToProperty(this, vm => vm.Accounts, initialValue: new ReadOnlyCollection<IAccount>(new IAccount[] { }));
+                .ToProperty(this, vm => vm.Accounts, initialValue: new ReadOnlyCollection<IAccount>(Array.Empty<IAccount>()));
 
             this.WhenAny(x => x.Accounts, x => x.Value)
                 .Select(accts => accts?.FirstOrDefault())