The PR viewmodel doesn't need to expose the notification service

Author: shana

src/GitHub.App/SampleData/PullRequestCreationViewModelDesigner.cs

@@ -3,10 +3,7 @@
 using System.Collections.Generic;
 using GitHub.Models;
 using GitHub.Validation;
-using System;
-using System.Windows.Input;
 using ReactiveUI;
-using GitHub.Services;
 
 namespace GitHub.SampleData
 {
@@ -48,7 +45,6 @@ public PullRequestCreationViewModelDesigner()
         public ReactivePropertyValidator TitleValidator { get; }
 
         public ReactivePropertyValidator BranchValidator { get; }
-        public INotificationService Notifications { get; }
 
     }
 }

src/GitHub.App/ViewModels/PullRequestCreationViewModel.cs

@@ -12,9 +12,6 @@
 using GitHub.Validation;
 using GitHub.Extensions;
 using NullGuard;
-using GitHub.UserErrors;
-using System.Globalization;
-using GitHub.App;
 
 namespace GitHub.ViewModels
 {
@@ -37,7 +34,6 @@ public PullRequestCreationViewModel(IRepositoryHost repositoryHost, ISimpleRepos
         {
             this.repositoryHost = repositoryHost;
             this.activeRepo = activeRepo;
-            this.Notifications = notifications;
 
             var repo = GitService.GitServiceHelper.GetRepo(activeRepo.LocalPath);
             this.WhenAny(x => x.Branches, x => x.Value)
@@ -93,7 +89,6 @@ public override void Initialize([AllowNull] ViewWithData data)
                             .Subscribe(x => Branches = x);
         }
 
-
         IBranch sourceBranch;
         [AllowNull]
         public IBranch SourceBranch
@@ -152,8 +147,5 @@ ReactivePropertyValidator BranchValidator
             get { return branchValidator; }
             set { this.RaiseAndSetIfChanged(ref branchValidator, value); }
         }
-
-        public INotificationService Notifications { get; }
-
     }
 }

src/GitHub.Exports.Reactive/ViewModels/IPullRequestCreationViewModel.cs

@@ -1,10 +1,7 @@
 using GitHub.Models;
-using GitHub.UI;
 using System.Collections.Generic;
-using System.Windows.Input;
 using GitHub.Validation;
 using ReactiveUI;
-using GitHub.Services;
 
 namespace GitHub.ViewModels
 {
@@ -16,7 +13,5 @@ public interface IPullRequestCreationViewModel : IReactiveViewModel
         IReactiveCommand<IPullRequestModel> CreatePullRequest { get; }
         string PRTitle { get; set; }
         ReactivePropertyValidator TitleValidator { get; }
-        INotificationService Notifications { get; }
-
     }
 }