Merge branch 'master' into fixes/1360-dispose-pane-pages

grokys · web-flow · commit a3feb6f7ce98 · 2017-12-18T10:06:41.000Z
diff --git a/src/GitHub.App/Factories/ViewViewModelFactory.cs b/src/GitHub.App/Factories/ViewViewModelFactory.cs
@@ -20,14 +20,12 @@ public class ViewViewModelFactory : IViewViewModelFactory
 
         [ImportingConstructor]
         public ViewViewModelFactory(
-            IGitHubServiceProvider serviceProvider,
-            ICompositionService cc)
+            IGitHubServiceProvider serviceProvider)
         {
             this.serviceProvider = serviceProvider;
-            cc.SatisfyImportsOnce(this);
         }
 
-        [ImportMany(AllowRecomposition = true)]
+        [ImportMany]
         IEnumerable<ExportFactory<FrameworkElement, IViewModelMetadata>> Views { get; set; }
 
         /// <inheritdoc/>
@@ -45,7 +43,7 @@ public FrameworkElement CreateView<TViewModel>() where TViewModel : IViewModel
         /// <inheritdoc/>
         public FrameworkElement CreateView(Type viewModel)
         {
-            var f = Views.FirstOrDefault(x => x.Metadata.ViewModelType.Contains(viewModel));
+            var f = Views.FirstOrDefault(x => x.Metadata.ViewModelType.Contains(viewModel.FullName));
             return f?.CreateExport().Value;
         }
     }
diff --git a/src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs b/src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs
@@ -61,7 +61,7 @@ public PullRequestDetailViewModelDesigner()
             var repositoriesDir = new PullRequestDirectoryNode("Repositories");
             var itrackingBranch = new PullRequestFileNode(repoPath, @"GitHub\Models\ITrackingBranch.cs", "abc", PullRequestFileStatus.Modified, null);
             var oldBranchModel = new PullRequestFileNode(repoPath, @"GitHub\Models\OldBranchModel.cs", "abc", PullRequestFileStatus.Removed, null);
-            var concurrentRepositoryConnection = new PullRequestFileNode(repoPath, @"GitHub\Repositories\ConcurrentRepositoryConnection.cs", "abc", PullRequestFileStatus.Added, "add");
+            var concurrentRepositoryConnection = new PullRequestFileNode(repoPath, @"GitHub\Repositories\ConcurrentRepositoryConnection.cs", "abc", PullRequestFileStatus.Added, null);
 
             repositoriesDir.Files.Add(concurrentRepositoryConnection);
             modelsDir.Directories.Add(repositoriesDir);
diff --git a/src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs b/src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs
@@ -372,7 +372,7 @@ async Task UpdateContent(ILocalRepositoryModel repository)
 
                 Connection = await connectionManager.GetConnection(hostAddress);
 
-                if (Connection != null)
+                if (Connection?.IsLoggedIn == true)
                 {
                     Content = navigator;
                     await ShowDefaultPage();
@@ -411,8 +411,8 @@ static async Task<bool> IsValidRepository(ISimpleApiClient client)
 
         static Regex CreateRoute(string route)
         {
-            // Build RegEx from route (:foo to named group (?<foo>[a-z0-9]+)).
-            var routeFormat = new Regex("(:([a-z]+))\\b").Replace(route, "(?<$2>[a-z0-9]+)");
+            // Build RegEx from route (:foo to named group (?<foo>[\w_.-]+)).
+            var routeFormat = new Regex("(:([a-z]+))\\b").Replace(route, @"(?<$2>[\w_.-]+)");
             return new Regex(routeFormat, RegexOptions.ExplicitCapture | RegexOptions.IgnoreCase);
         }
     }
diff --git a/src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs b/src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs
@@ -473,6 +473,12 @@ public Task<string> ExtractFile(IPullRequestFileNode file, bool head)
         {
             var relativePath = Path.Combine(file.DirectoryPath, file.FileName);
             var encoding = pullRequestsService.GetEncoding(LocalRepository, relativePath);
+
+            if (!head && file.OldPath != null)
+            {
+                relativePath = file.OldPath;
+            }
+
             return pullRequestsService.ExtractFile(LocalRepository, model, relativePath, head, encoding).ToTask();
         }
 
@@ -552,7 +558,7 @@ async Task<IPullRequestDirectoryNode> CreateChangedFilesTree(IPullRequestModel p
                     changedFile.FileName,
                     changedFile.Sha,
                     changedFile.Status,
-                    GetStatusDisplay(changedFile, changes));
+                    GetOldFileName(changedFile, changes));
 
                 var file = await Session.GetFile(changedFile.FileName);
                 var fileCommentCount = file?.WhenAnyValue(x => x.InlineCommentThreads)
@@ -598,28 +604,15 @@ static string GetBranchDisplayName(bool isFromFork, string targetBranchLabel)
             }
         }
 
-        string GetStatusDisplay(IPullRequestFileModel file, TreeChanges changes)
+        string GetOldFileName(IPullRequestFileModel file, TreeChanges changes)
         {
-            switch (file.Status)
+            if (file.Status == PullRequestFileStatus.Renamed)
             {
-                case PullRequestFileStatus.Added:
-                    return Resources.AddedFileStatus;
-                case PullRequestFileStatus.Renamed:
-                    var fileName = file.FileName.Replace("/", "\\");
-                    var change = changes?.Renamed.FirstOrDefault(x => x.Path == fileName);
-
-                    if (change != null)
-                    {
-                        return Path.GetDirectoryName(change.OldPath) == Path.GetDirectoryName(change.Path) ?
-                            Path.GetFileName(change.OldPath) : change.OldPath;
-                    }
-                    else
-                    {
-                        return Resources.RenamedFileStatus;
-                    }
-                default:
-                    return null;
+                var fileName = file.FileName.Replace("/", "\\");
+                return changes?.Renamed.FirstOrDefault(x => x.Path == fileName)?.OldPath;
             }
+
+            return null;
         }
 
         IObservable<Unit> DoCheckout(object unused)
diff --git a/src/GitHub.App/ViewModels/GitHubPane/PullRequestFileNode.cs b/src/GitHub.App/ViewModels/GitHubPane/PullRequestFileNode.cs
@@ -1,5 +1,6 @@
 ﻿using System;
 using System.IO;
+using GitHub.App;
 using GitHub.Extensions;
 using GitHub.Models;
 using ReactiveUI;
@@ -21,23 +22,43 @@ public class PullRequestFileNode : ReactiveObject, IPullRequestFileNode
         /// <param name="sha">The SHA of the file.</param>
         /// <param name="status">The way the file was changed.</param>
         /// <param name="statusDisplay">The string to display in the [message] box next to the filename.</param>
+        /// <param name="oldPath">
+        /// The old path of a moved/renamed file, relative to the repository. Should be null if the
+        /// file was not moved/renamed.
+        /// </param>
         public PullRequestFileNode(
             string repositoryPath,
             string path,
             string sha,
             PullRequestFileStatus status,
-            string statusDisplay)
+            string oldPath)
         {
             Guard.ArgumentNotEmptyString(repositoryPath, nameof(repositoryPath));
             Guard.ArgumentNotEmptyString(path, nameof(path));
             Guard.ArgumentNotEmptyString(sha, nameof(sha));
 
             FileName = Path.GetFileName(path);
             DirectoryPath = Path.GetDirectoryName(path);
-            DisplayPath = Path.Combine(Path.GetFileName(repositoryPath), DirectoryPath);
             Sha = sha;
             Status = status;
-            StatusDisplay = statusDisplay;
+            OldPath = oldPath;
+
+            if (status == PullRequestFileStatus.Added)
+            {
+                StatusDisplay = Resources.AddedFileStatus;
+            }
+            else if (status == PullRequestFileStatus.Renamed)
+            {
+                if (oldPath != null)
+                {
+                    StatusDisplay = Path.GetDirectoryName(oldPath) == Path.GetDirectoryName(path) ?
+                            Path.GetFileName(oldPath) : oldPath;
+                }
+                else
+                {
+                    StatusDisplay = Resources.RenamedFileStatus;
+                }
+            }
         }
 
         /// <summary>
@@ -51,9 +72,9 @@ public PullRequestFileNode(
         public string DirectoryPath { get; }
 
         /// <summary>
-        /// Gets the path to display in the "Path" column of the changed files list.
+        /// Gets the old path of a moved/renamed file, relative to the root of the repository.
         /// </summary>
-        public string DisplayPath { get; }
+        public string OldPath { get; }
 
         /// <summary>
         /// Gets the SHA of the file.
diff --git a/src/GitHub.App/ViewModels/GitHubPane/PullRequestListViewModel.cs b/src/GitHub.App/ViewModels/GitHubPane/PullRequestListViewModel.cs
@@ -88,6 +88,10 @@ public PullRequestListViewModel(
                 .Where(x => PullRequests != null)
                 .Subscribe(f => UpdateFilter(SelectedState, SelectedAssignee, SelectedAuthor, f));
 
+            this.WhenAnyValue(x => x.SelectedRepository)
+                .Skip(1)
+                .Subscribe(_ => ResetAndLoad());
+
             OpenPullRequest = ReactiveCommand.Create();
             OpenPullRequest.Subscribe(DoOpenPullRequest);
             CreatePullRequest = ReactiveCommand.Create();
@@ -117,9 +121,9 @@ public async Task InitializeAsync(ILocalRepositoryModel repository, IConnection
                     new[] { remoteRepository.Parent, remoteRepository } :
                     new[] { remoteRepository };
                 SelectedState = States.FirstOrDefault(x => x.Name == listSettings.SelectedState) ?? States[0];
+
+                // Setting SelectedRepository will cause a Load().
                 SelectedRepository = Repositories[0];
-                WebUrl = repository.CloneUrl?.ToRepositoryUrl().Append("pulls");
-                await Load();
             }
             finally
             {
@@ -324,6 +328,7 @@ void CreatePullRequests()
 
         void ResetAndLoad()
         {
+            WebUrl = SelectedRepository.CloneUrl?.ToRepositoryUrl().Append("pulls");
             CreatePullRequests();
             UpdateFilter(SelectedState, SelectedAssignee, SelectedAuthor, SearchQuery);
             Load().Forget();
diff --git a/src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestFileNode.cs b/src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestFileNode.cs
@@ -10,9 +10,9 @@ public interface IPullRequestFileNode : IPullRequestChangeNode
         string FileName { get; }
 
         /// <summary>
-        /// Gets the path to display in the "Path" column of the changed files list.
+        /// Gets the old path of a moved/renamed file, relative to the root of the repository.
         /// </summary>
-        string DisplayPath { get; }
+        string OldPath { get; }
 
         /// <summary>
         /// Gets the SHA of the file.
diff --git a/src/GitHub.Exports/Exports/ExportMetadata.cs b/src/GitHub.Exports/Exports/ExportMetadata.cs
@@ -32,15 +32,17 @@ public enum LinkType
     /// </summary>
     [MetadataAttribute]
     [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
+    [SuppressMessage("Microsoft.Design", "CA1019:DefineAccessorsForAttributeArguments",
+        Justification = "Store string rather than Type as metadata")]
     public sealed class ExportViewForAttribute : ExportAttribute
     {
         public ExportViewForAttribute(Type viewModelType)
             : base(typeof(FrameworkElement))
         {
-            ViewModelType = viewModelType;
+            ViewModelType = viewModelType.FullName;
         }
 
-        public Type ViewModelType { get; }
+        public string ViewModelType { get; }
     }
 
     /// <summary>
@@ -69,7 +71,7 @@ public ExportMenuAttribute() : base(typeof(IMenuHandler))
     public interface IViewModelMetadata
     {
         [SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
-        Type[] ViewModelType { get; }
+        string[] ViewModelType { get; }
     }
 
     /// <summary>
diff --git a/src/GitHub.TeamFoundation.14/RegistryHelper.cs b/src/GitHub.TeamFoundation.14/RegistryHelper.cs
@@ -21,28 +21,42 @@ static RegistryKey OpenGitKey(string path)
 
         internal static IEnumerable<ILocalRepositoryModel> PokeTheRegistryForRepositoryList()
         {
-            using (var key = OpenGitKey("Repositories"))
+            var key = OpenGitKey("Repositories");
+
+            if (key != null)
             {
-                return key.GetSubKeyNames().Select(x =>
+                using (key)
                 {
-                    using (var subkey = key.OpenSubKey(x))
+                    return key.GetSubKeyNames().Select(x =>
                     {
-                        try
-                        {
-                            var path = subkey?.GetValue("Path") as string;
-                            if (path != null && Directory.Exists(path))
-                                return new LocalRepositoryModel(path);
-                        }
-                        catch (Exception)
+                        var subkey = key.OpenSubKey(x);
+
+                        if (subkey != null)
                         {
-                            // no sense spamming the log, the registry might have ton of stale things we don't care about
+                            using (subkey)
+                            {
+                                try
+                                {
+                                    var path = subkey?.GetValue("Path") as string;
+                                    if (path != null && Directory.Exists(path))
+                                        return new LocalRepositoryModel(path);
+                                }
+                                catch (Exception)
+                                {
+                                    // no sense spamming the log, the registry might have ton of stale things we don't care about
+                                }
+
+                            }
                         }
+
                         return null;
-                    }
-                })
-                .Where(x => x != null)
-                .ToList();
+                    })
+                    .Where(x => x != null)
+                    .ToList();
+                }
             }
+
+            return new ILocalRepositoryModel[0];
         }
 
         internal static string PokeTheRegistryForLocalClonePath()
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/GitHubPaneView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/GitHubPaneView.xaml
@@ -10,6 +10,7 @@
              xmlns:uc="clr-namespace:GitHub.UI.Controls;assembly=GitHub.UI"
              xmlns:vuc="clr-namespace:GitHub.VisualStudio.UI.Controls;assembly=GitHub.VisualStudio.UI"
              xmlns:views="clr-namespace:GitHub.VisualStudio.Views"
+             Foreground="{DynamicResource GitHubVsWindowText}"
              d:DesignHeight="300"
              d:DesignWidth="300"
              mc:Ignorable="d">
@@ -82,8 +83,7 @@
                   HorizontalAlignment="Center"
                   VerticalAlignment="Center"
                   Visibility="{Binding ContentOverride, Converter={u:EqualsToVisibilityConverter Spinner}, FallbackValue=Collapsed}"/>
-      <Border Background="White"
-              HorizontalAlignment="Stretch"
+      <Border HorizontalAlignment="Stretch"
               VerticalAlignment="Stretch"
               Visibility="{Binding ContentOverride, Converter={u:EqualsToVisibilityConverter Error}, FallbackValue=Collapsed}">
         <StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
@@ -317,9 +317,13 @@
                                                 <ui:OcticonImage.Style>
                                                     <Style TargetType="ui:OcticonImage" BasedOn="{StaticResource OcticonImage}">
                                                         <Style.Triggers>
-                                                            <DataTrigger Binding="{Binding Status}" Value="Removed">
+                                                            <MultiDataTrigger>
+                                                                <MultiDataTrigger.Conditions>
+                                                                    <Condition Binding="{Binding Status}" Value="Removed"/>
+                                                                    <Condition Binding="{Binding RelativeSource={RelativeSource AncestorType={x:Type TreeViewItem}}, Path=IsSelected}" Value="False"/>
+                                                                </MultiDataTrigger.Conditions>
                                                                 <Setter Property="Foreground" Value="{DynamicResource GitHubDeletedFileIconBrush}"/>
-                                                            </DataTrigger>
+                                                            </MultiDataTrigger>
                                                         </Style.Triggers>
                                                     </Style>
                                                 </ui:OcticonImage.Style>
@@ -329,9 +333,15 @@
                                                     <Style TargetType="TextBlock">
                                                         <Style.Triggers>
                                                             <DataTrigger Binding="{Binding Status}" Value="Removed">
-                                                                <Setter Property="Foreground" Value="{DynamicResource GitHubDeletedFileBrush}"/>
                                                                 <Setter Property="TextDecorations" Value="Strikethrough"/>
                                                             </DataTrigger>
+                                                            <MultiDataTrigger>
+                                                                <MultiDataTrigger.Conditions>
+                                                                    <Condition Binding="{Binding Status}" Value="Removed"/>
+                                                                    <Condition Binding="{Binding RelativeSource={RelativeSource AncestorType={x:Type TreeViewItem}}, Path=IsSelected}" Value="False"/>
+                                                                </MultiDataTrigger.Conditions>
+                                                                <Setter Property="Foreground" Value="{DynamicResource GitHubDeletedFileBrush}"/>
+                                                            </MultiDataTrigger>
                                                         </Style.Triggers>
                                                     </Style>
                                                 </TextBlock.Style>
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml.cs b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml.cs
@@ -123,12 +123,12 @@ async Task DoDiffFile(IPullRequestFileNode file, bool workingDirectory)
         {
             try
             {
-                var relativePath = System.IO.Path.Combine(file.DirectoryPath, file.FileName);
+                var rightPath = System.IO.Path.Combine(file.DirectoryPath, file.FileName);
+                var leftPath = file.OldPath ?? rightPath;
                 var rightFile = workingDirectory ? ViewModel.GetLocalFilePath(file) : await ViewModel.ExtractFile(file, true);
                 var leftFile = await ViewModel.ExtractFile(file, false);
-                var fullPath = System.IO.Path.Combine(ViewModel.LocalRepository.LocalPath, relativePath);
-                var leftLabel = $"{relativePath};{ViewModel.TargetBranchDisplayName}";
-                var rightLabel = workingDirectory ? relativePath : $"{relativePath};PR {ViewModel.Model.Number}";
+                var leftLabel = $"{leftPath};{ViewModel.TargetBranchDisplayName}";
+                var rightLabel = workingDirectory ? rightPath : $"{rightPath};PR {ViewModel.Model.Number}";
                 var caption = $"Diff - {file.FileName}";
                 var options = __VSDIFFSERVICEOPTIONS.VSDIFFOPT_DetectBinaryFiles |
                     __VSDIFFSERVICEOPTIONS.VSDIFFOPT_LeftFileIsTemporary;
@@ -161,11 +161,11 @@ async Task DoDiffFile(IPullRequestFileNode file, bool workingDirectory)
                 var diffViewer = ((IVsDifferenceCodeWindow)docView).DifferenceViewer;
 
                 var session = ViewModel.Session;
-                AddBufferTag(diffViewer.LeftView.TextBuffer, session, relativePath, DiffSide.Left);
+                AddBufferTag(diffViewer.LeftView.TextBuffer, session, leftPath, DiffSide.Left);
 
                 if (!workingDirectory)
                 {
-                    AddBufferTag(diffViewer.RightView.TextBuffer, session, relativePath, DiffSide.Right);
+                    AddBufferTag(diffViewer.RightView.TextBuffer, session, rightPath, DiffSide.Right);
                 }
 
                 if (workingDirectory)
diff --git a/src/GitHub.VisualStudio/source.extension.vsixmanifest b/src/GitHub.VisualStudio/source.extension.vsixmanifest
diff --git a/test/UnitTests/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModelTests.cs b/test/UnitTests/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModelTests.cs

Original file line number	Diff line number	Diff line change
`@@ -20,14 +20,12 @@ public class ViewViewModelFactory : IViewViewModelFactory`
`20`	`20`
`21`	`21`	`[ImportingConstructor]`
`22`	`22`	`public ViewViewModelFactory(`
`23`		`- IGitHubServiceProvider serviceProvider,`
`24`		`- ICompositionService cc)`
	`23`	`+ IGitHubServiceProvider serviceProvider)`
`25`	`24`	`{`
`26`	`25`	`this.serviceProvider = serviceProvider;`
`27`		`- cc.SatisfyImportsOnce(this);`
`28`	`26`	`}`
`29`	`27`
`30`		`- [ImportMany(AllowRecomposition = true)]`
	`28`	`+ [ImportMany]`
`31`	`29`	`IEnumerable<ExportFactory<FrameworkElement, IViewModelMetadata>> Views { get; set; }`
`32`	`30`
`33`	`31`	`/// <inheritdoc/>`
`@@ -45,7 +43,7 @@ public FrameworkElement CreateView<TViewModel>() where TViewModel : IViewModel`
`45`	`43`	`/// <inheritdoc/>`
`46`	`44`	`public FrameworkElement CreateView(Type viewModel)`
`47`	`45`	`{`
`48`		`- var f = Views.FirstOrDefault(x => x.Metadata.ViewModelType.Contains(viewModel));`
	`46`	`+ var f = Views.FirstOrDefault(x => x.Metadata.ViewModelType.Contains(viewModel.FullName));`
`49`	`47`	`return f?.CreateExport().Value;`
`50`	`48`	`}`
`51`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ async Task UpdateContent(ILocalRepositoryModel repository)`
`372`	`372`
`373`	`373`	`Connection = await connectionManager.GetConnection(hostAddress);`
`374`	`374`
`375`		`- if (Connection != null)`
	`375`	`+ if (Connection?.IsLoggedIn == true)`
`376`	`376`	`{`
`377`	`377`	`Content = navigator;`
`378`	`378`	`await ShowDefaultPage();`
`@@ -411,8 +411,8 @@ static async Task<bool> IsValidRepository(ISimpleApiClient client)`
`411`	`411`
`412`	`412`	`static Regex CreateRoute(string route)`
`413`	`413`	`{`
`414`		`- // Build RegEx from route (:foo to named group (?<foo>[a-z0-9]+)).`
`415`		`- var routeFormat = new Regex("(:([a-z]+))\\b").Replace(route, "(?<$2>[a-z0-9]+)");`
	`414`	`+ // Build RegEx from route (:foo to named group (?<foo>[\w_.-]+)).`
	`415`	`+ var routeFormat = new Regex("(:([a-z]+))\\b").Replace(route, @"(?<$2>[\w_.-]+)");`
`416`	`416`	`return new Regex(routeFormat, RegexOptions.ExplicitCapture \| RegexOptions.IgnoreCase);`
`417`	`417`	`}`
`418`	`418`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,17 @@ public enum LinkType`
`32`	`32`	`/// </summary>`
`33`	`33`	`[MetadataAttribute]`
`34`	`34`	`[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]`
	`35`	`+ [SuppressMessage("Microsoft.Design", "CA1019:DefineAccessorsForAttributeArguments",`
	`36`	`+ Justification = "Store string rather than Type as metadata")]`
`35`	`37`	`public sealed class ExportViewForAttribute : ExportAttribute`
`36`	`38`	`{`
`37`	`39`	`public ExportViewForAttribute(Type viewModelType)`
`38`	`40`	`: base(typeof(FrameworkElement))`
`39`	`41`	`{`
`40`		`- ViewModelType = viewModelType;`
	`42`	`+ ViewModelType = viewModelType.FullName;`
`41`	`43`	`}`
`42`	`44`
`43`		`- public Type ViewModelType { get; }`
	`45`	`+ public string ViewModelType { get; }`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`/// <summary>`
`@@ -69,7 +71,7 @@ public ExportMenuAttribute() : base(typeof(IMenuHandler))`
`69`	`71`	`public interface IViewModelMetadata`
`70`	`72`	`{`
`71`	`73`	`[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]`
`72`		`- Type[] ViewModelType { get; }`
	`74`	`+ string[] ViewModelType { get; }`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`/// <summary>`