Merge pull request #2332 from github/fixes/2323-keyboard-navigation

Fix keyboard navigation and focus on clone dialog

Author: jcansdale

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/RepositoryCloneView.xaml

@@ -26,26 +26,30 @@
                 IsDefault="True"
                 Command="{Binding Clone}"
                 Content="Clone"
-                AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.CloneRepositoryButton}"/>
+                AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.CloneRepositoryButton}"
+                KeyboardNavigation.TabIndex="5" />
 
             <Button
                 Margin="6,0,0,0"
                 HorizontalAlignment="Center"
                 IsDefault="True"
                 Command="{Binding Open}"
                 Content="Open"
-                AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.OpenRepositoryButton}"/>
+                AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.OpenRepositoryButton}"
+                KeyboardNavigation.TabIndex="6"/>
         </StackPanel>
 
         <DockPanel DockPanel.Dock="Bottom" Margin="0,9,0,0">
             <Label DockPanel.Dock="Left" Content="{x:Static ghfvs:Resources.localPathText}" />
             <Button DockPanel.Dock="Right"
                     Command="{Binding Browse}"
-                    VerticalContentAlignment="Center">
+                    VerticalContentAlignment="Center"
+                    KeyboardNavigation.TabIndex="4">
                 Browse...
             </Button>
             <TextBox Text="{Binding Path, UpdateSourceTrigger=PropertyChanged}" Margin="6,0"
-                     VerticalContentAlignment="Center" />
+                     VerticalContentAlignment="Center"
+                     KeyboardNavigation.TabIndex="3" />
         </DockPanel>
 
         <uic:InfoPanel Message="{Binding PathWarning}"

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/SelectPageView.xaml

@@ -14,17 +14,20 @@
     </Control.Resources>
 
     <DockPanel>
-        <ghfvs:PromptTextBox DockPanel.Dock="Top"
+        <ghfvs:PromptTextBox Name="SearchTextBox"
+                             DockPanel.Dock="Top"
                              Margin="0,9"
-                             PromptText="Search or enter a URL"
-                             Text="{Binding Filter, UpdateSourceTrigger=PropertyChanged, Delay=300}"/>
+                             PromptText="Search or enter a URL"                             
+                             Text="{Binding Filter, UpdateSourceTrigger=PropertyChanged, Delay=300}"
+                             KeyboardNavigation.TabIndex="1" />
 
         <Grid>
             <ListView BorderThickness="0"
                       ItemsSource="{Binding ItemsView}"
                       SelectedItem="{Binding SelectedItem}"
                       VirtualizingPanel.IsVirtualizing="True"
-                      VirtualizingPanel.IsVirtualizingWhenGrouping="True">
+                      VirtualizingPanel.IsVirtualizingWhenGrouping="True"
+                      KeyboardNavigation.TabIndex="2">
                 <ListView.GroupStyle>
                     <GroupStyle>
                         <GroupStyle.HeaderTemplate>

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/SelectPageView.xaml.cs

@@ -1,6 +1,8 @@
-using System.ComponentModel.Composition;
+using System;
+using System.ComponentModel.Composition;
 using System.Windows.Controls;
 using System.Windows.Input;
+using System.Windows.Threading;
 using GitHub.Exports;
 using GitHub.ViewModels.Dialog.Clone;
 
@@ -13,6 +15,16 @@ public partial class SelectPageView : UserControl
         public SelectPageView()
         {
             InitializeComponent();
+
+            // See Douglas Stockwell's suggestion:
+            // https://social.msdn.microsoft.com/Forums/vstudio/en-US/30ed27ce-f7b7-48ae-8adc-0400b9b9ec78
+            IsVisibleChanged += (sender, e) =>
+            {
+                if (IsVisible)
+                {
+                    Dispatcher.BeginInvoke(DispatcherPriority.Input, (Action)(() => SearchTextBox.Focus()));
+                }
+            };
         }
 
         protected override void OnPreviewMouseDown(MouseButtonEventArgs e)